From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:33084 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbeETIpB (ORCPT ); Sun, 20 May 2018 04:45:01 -0400 From: Laurent Pinchart To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/5] drm: rcar-du: lvds: Add R8A77995 support Date: Sun, 20 May 2018 11:45:24 +0300 Message-ID: <3888488.E5UaB3ZWWj@avalon> In-Reply-To: <1526386840-15368-3-git-send-email-ulrich.hecht+renesas@gmail.com> References: <1526386840-15368-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1526386840-15368-3-git-send-email-ulrich.hecht+renesas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Ulrich, Thank you for the patch. On Tuesday, 15 May 2018 15:20:37 EEST Ulrich Hecht wrote: > Add support for the R-Car D3 (R8A77995) SoC to the LVDS encoder driver. > > Signed-off-by: Ulrich Hecht > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c > b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 3d2d3bb..58fb9f8 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -511,6 +511,11 @@ static const struct rcar_lvds_device_info > rcar_lvds_r8a77970_info = { .quirks = RCAR_LVDS_QUIRK_GEN2_PLLCR | > RCAR_LVDS_QUIRK_GEN3_LVEN, }; > > +static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = { > + .gen = 3, > + .quirks = RCAR_LVDS_QUIRK_GEN3_LVEN, I'm afraid this won't be enough. With this patch the driver will call rcar_lvds_lvdpllcr_gen3(), which writes values to the LVDPLLCR register that don't match the register layout for D3. While I'm fine with an initial version that doesn't support fine-grained control of the LVDS PLL to achieve the HDMI clock accuracy requirements, we need the LVDS encoder to be at least functional for the patches to get merged. There are also other registers not related to the PLL that need to be set (such as the LVDSTRIPE register), and other differences in register layouts (for instance the D3 doesn't have a PLLON bit in register LVDC0). Even the LVEN bit seems to need special handling on D3. According to version 1.00 of the datasheet it should be set to 1 at the same time as bit LVRES. Could you please study the datasheet in details and update the code accordingly ? > +}; > + > static const struct of_device_id rcar_lvds_of_table[] = { > { .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info }, > { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info }, > @@ -519,6 +524,7 @@ static const struct of_device_id rcar_lvds_of_table[] = > { { .compatible = "renesas,r8a7795-lvds", .data = &rcar_lvds_gen3_info }, { > .compatible = "renesas,r8a7796-lvds", .data = &rcar_lvds_gen3_info }, { > .compatible = "renesas,r8a77970-lvds", .data = &rcar_lvds_r8a77970_info }, > + { .compatible = "renesas,r8a77995-lvds", .data = &rcar_lvds_r8a77995_info > }, { } > }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/5] drm: rcar-du: lvds: Add R8A77995 support Date: Sun, 20 May 2018 11:45:24 +0300 Message-ID: <3888488.E5UaB3ZWWj@avalon> References: <1526386840-15368-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1526386840-15368-3-git-send-email-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3564C6E190 for ; Sun, 20 May 2018 08:45:01 +0000 (UTC) In-Reply-To: <1526386840-15368-3-git-send-email-ulrich.hecht+renesas@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVWxyaWNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxNSBNYXkg MjAxOCAxNToyMDozNyBFRVNUIFVscmljaCBIZWNodCB3cm90ZToKPiBBZGQgc3VwcG9ydCBmb3Ig dGhlIFItQ2FyIEQzIChSOEE3Nzk5NSkgU29DIHRvIHRoZSBMVkRTIGVuY29kZXIgZHJpdmVyLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFVscmljaCBIZWNodCA8dWxyaWNoLmhlY2h0K3JlbmVzYXNAZ21h aWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2x2ZHMuYyB8IDYg KysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9sdmRzLmMKPiBiL2RyaXZlcnMvZ3B1L2Ry bS9yY2FyLWR1L3JjYXJfbHZkcy5jIGluZGV4IDNkMmQzYmIuLjU4ZmI5ZjggMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9sdmRzLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2x2ZHMuYwo+IEBAIC01MTEsNiArNTExLDExIEBAIHN0YXRpYyBj b25zdCBzdHJ1Y3QgcmNhcl9sdmRzX2RldmljZV9pbmZvCj4gcmNhcl9sdmRzX3I4YTc3OTcwX2lu Zm8gPSB7IC5xdWlya3MgPSBSQ0FSX0xWRFNfUVVJUktfR0VOMl9QTExDUiB8Cj4gUkNBUl9MVkRT X1FVSVJLX0dFTjNfTFZFTiwgfTsKPiAKPiArc3RhdGljIGNvbnN0IHN0cnVjdCByY2FyX2x2ZHNf ZGV2aWNlX2luZm8gcmNhcl9sdmRzX3I4YTc3OTk1X2luZm8gPSB7Cj4gKwkuZ2VuID0gMywKPiAr CS5xdWlya3MgPSBSQ0FSX0xWRFNfUVVJUktfR0VOM19MVkVOLAoKSSdtIGFmcmFpZCB0aGlzIHdv bid0IGJlIGVub3VnaC4gV2l0aCB0aGlzIHBhdGNoIHRoZSBkcml2ZXIgd2lsbCBjYWxsIApyY2Fy X2x2ZHNfbHZkcGxsY3JfZ2VuMygpLCB3aGljaCB3cml0ZXMgdmFsdWVzIHRvIHRoZSBMVkRQTExD UiByZWdpc3RlciB0aGF0IApkb24ndCBtYXRjaCB0aGUgcmVnaXN0ZXIgbGF5b3V0IGZvciBEMy4K CldoaWxlIEknbSBmaW5lIHdpdGggYW4gaW5pdGlhbCB2ZXJzaW9uIHRoYXQgZG9lc24ndCBzdXBw b3J0IGZpbmUtZ3JhaW5lZCAKY29udHJvbCBvZiB0aGUgTFZEUyBQTEwgdG8gYWNoaWV2ZSB0aGUg SERNSSBjbG9jayBhY2N1cmFjeSByZXF1aXJlbWVudHMsIHdlIApuZWVkIHRoZSBMVkRTIGVuY29k ZXIgdG8gYmUgYXQgbGVhc3QgZnVuY3Rpb25hbCBmb3IgdGhlIHBhdGNoZXMgdG8gZ2V0IG1lcmdl ZC4KClRoZXJlIGFyZSBhbHNvIG90aGVyIHJlZ2lzdGVycyBub3QgcmVsYXRlZCB0byB0aGUgUExM IHRoYXQgbmVlZCB0byBiZSBzZXQgCihzdWNoIGFzIHRoZSBMVkRTVFJJUEUgcmVnaXN0ZXIpLCBh bmQgb3RoZXIgZGlmZmVyZW5jZXMgaW4gcmVnaXN0ZXIgbGF5b3V0cyAKKGZvciBpbnN0YW5jZSB0 aGUgRDMgZG9lc24ndCBoYXZlIGEgUExMT04gYml0IGluIHJlZ2lzdGVyIExWREMwKS4KCkV2ZW4g dGhlIExWRU4gYml0IHNlZW1zIHRvIG5lZWQgc3BlY2lhbCBoYW5kbGluZyBvbiBEMy4gQWNjb3Jk aW5nIHRvIHZlcnNpb24gCjEuMDAgb2YgdGhlIGRhdGFzaGVldCBpdCBzaG91bGQgYmUgc2V0IHRv IDEgYXQgdGhlIHNhbWUgdGltZSBhcyBiaXQgTFZSRVMuCgpDb3VsZCB5b3UgcGxlYXNlIHN0dWR5 IHRoZSBkYXRhc2hlZXQgaW4gZGV0YWlscyBhbmQgdXBkYXRlIHRoZSBjb2RlIAphY2NvcmRpbmds eSA/Cgo+ICt9Owo+ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgcmNhcl9s dmRzX29mX3RhYmxlW10gPSB7Cj4gIAl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMscjhhNzc0My1s dmRzIiwgLmRhdGEgPSAmcmNhcl9sdmRzX2dlbjJfaW5mbyB9LAo+ICAJeyAuY29tcGF0aWJsZSA9 ICJyZW5lc2FzLHI4YTc3OTAtbHZkcyIsIC5kYXRhID0gJnJjYXJfbHZkc19yOGE3NzkwX2luZm8g fSwKPiBAQCAtNTE5LDYgKzUyNCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lk IHJjYXJfbHZkc19vZl90YWJsZVtdID0KPiB7IHsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxyOGE3 Nzk1LWx2ZHMiLCAuZGF0YSA9ICZyY2FyX2x2ZHNfZ2VuM19pbmZvIH0sIHsKPiAuY29tcGF0aWJs ZSA9ICJyZW5lc2FzLHI4YTc3OTYtbHZkcyIsIC5kYXRhID0gJnJjYXJfbHZkc19nZW4zX2luZm8g fSwgewo+IC5jb21wYXRpYmxlID0gInJlbmVzYXMscjhhNzc5NzAtbHZkcyIsIC5kYXRhID0gJnJj YXJfbHZkc19yOGE3Nzk3MF9pbmZvIH0sCj4gKwl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMscjhh Nzc5OTUtbHZkcyIsIC5kYXRhID0gJnJjYXJfbHZkc19yOGE3Nzk5NV9pbmZvCj4gfSwgeyB9Cj4g IH07CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==