From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/4 v2] Audio support for adv7511 hdmi bridge Date: Tue, 30 Aug 2016 12:23 +0300 Message-ID: <3891360.bEMoZb6Wzz@avalon> References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64FC16E616 for ; Tue, 30 Aug 2016 09:22:39 +0000 (UTC) In-Reply-To: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: Guodong Xu , dri-devel@lists.freedesktop.org, lkml , Jose Abreu , Wolfram Sang , Mark Brown , Srinivas Kandagatla , Dave Long , Andy Green , Zhangfei Gao List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoZXMuCgpPbiBNb25kYXkgMjkgQXVnIDIw MTYgMTY6NDE6MzIgSm9obiBTdHVsdHogd3JvdGU6Cj4gVGhpcyBpcyBhbm90aGVyIHN3aW5nIGF0 IGdldHRpbmcgdGhlIGFkdjc1MTEgaGRtaSBicmlkZ2UKPiBhdWRpbyBzdXBwb3J0IHJldmlld2Vk Lgo+IAo+IEkndmUgdGFrZW4gdGhlIGNvcmUgYXVkaW8gd29yayBkb25lIGJ5IExhcnMtUGV0ZXIg Q2xhdXNlbiwgYW5kCj4gYWRhcHRlZCBieSBTcmluaXZhcyBLYW5kYWdhdGxhIGFuZCBBcmNoaXQg VGFuZWphLCBhbmQgdHJpZWQgdG8KPiByZXdvcmsgaXQgdG8gdXNlIHRoZSBoZG1pLWNvZGVjIHNv dW5kIGRyaXZlci4KPiAKPiBUaGlzIHBhdGNoc2V0LCBhbG9uZyB3aXRoIHRoZSBpMnMgZHJpdmVy IGFuZCBkdHMgY2hhbmdlcyBhbGxvd3MKPiBIRE1JIGF1ZGlvIHRvIHdvcmsgb24gdGhlIEhpS2V5 IGJvYXJkLgoKV2hlcmUgYXJlIHRoZSBkdHMgY2hhbmdlcyA/Cgo+IEknZCByZWFsbHkgYXBwcmVj aWF0ZSBhbnkgdGhvdWdodHMgb3IgZmVlZGJhY2suCj4gCj4gTmV3IGluIHYyOgo+ICogSW50ZWdy YXRlZCBTcmluaXZhcycgcmV2aWV3IGZlZWRiYWNrCj4gCj4gdGhhbmtzCj4gLWpvaG4KPiAKPiBD YzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBBcmNoaXQgVGFuZWphIDxh cmNoaXR0QGNvZGVhdXJvcmEub3JnPgo+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBp bmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gQ2M6IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNA c2FuZy1lbmdpbmVlcmluZy5jb20+Cj4gQ2M6IFNyaW5pdmFzIEthbmRhZ2F0bGEgPHNyaW5pdmFz LmthbmRhZ2F0bGFAbGluYXJvLm9yZz4KPiBDYzogIlZpbGxlIFN5cmrDpGzDpCIgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXpp bGxvbkBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gQ2M6IEFuZHkgR3JlZW4gPGFuZHlAd2FybWNhdC5j b20+Cj4gQ2M6IERhdmUgTG9uZyA8ZGF2ZS5sb25nQGxpbmFyby5vcmc+Cj4gQ2M6IEd1b2Rvbmcg WHUgPGd1b2RvbmcueHVAbGluYXJvLm9yZz4KPiBDYzogWmhhbmdmZWkgR2FvIDx6aGFuZ2ZlaS5n YW9AbGluYXJvLm9yZz4KPiBDYzogTWFyayBCcm93biA8YnJvb25pZUBrZXJuZWwub3JnPgo+IENj OiBMYXJzLVBldGVyIENsYXVzZW4gPGxhcnNAbWV0YWZvby5kZT4KPiBDYzogSm9zZSBBYnJldSA8 am9hYnJldUBzeW5vcHN5cy5jb20+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiAKPiBBbmR5IEdyZWVuICgxKToKPiAgIGRybS9icmlkZ2U6IGFkdjc1MTE6IEluaXRpYWxp emUgYXVkaW8gcGFja2V0IG9uIGFkdjc1MzMKPiAKPiBBcmNoaXQgVGFuZWphICgxKToKPiAgIGRy bS9icmlkZ2U6IGFkdjc1MTE6IE1vdmUgdGhlIGNvbW1vbiBkYXRhIHN0cnVjdHVyZXMgdG8gaGVh ZGVyIGZpbGUKPiAKPiBKb2huIFN0dWx0eiAoMSk6Cj4gICBkcm0vYnJpZGdlOiBhZHY3NTExOiBB ZGQgQXVkaW8gc3VwcG9ydC4KPiAKPiBTcmluaXZhcyBLYW5kYWdhdGxhICgxKToKPiAgIGRybS9i cmlkZ2U6IGFkdjc1MTE6IEVuYWJsZSB0aGUgYXVkaW8gZGF0YSBhbmQgY2xvY2sgcGFkcyBvbiBh ZHY3NTMzCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9LY29uZmlnICAgICAg ICAgfCAgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvTWFrZWZpbGUgICAg ICAgIHwgICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExLmgg ICAgICAgfCAgMTMgKysKPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFf YXVkaW8uYyB8IDE5OSArKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jICAgfCAgIDkgKy0KPiAgZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9hZHY3NTExL2Fkdjc1MzMuYyAgICAgICB8ICAyMyArKysKPiAgNiBmaWxlcyBjaGFu Z2VkLCAyNDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAgY3JlYXRlIG1vZGUgMTAw NjQ0IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2F1ZGlvLmMKCi0tIApS ZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757771AbcH3JWl (ORCPT ); Tue, 30 Aug 2016 05:22:41 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:36400 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755400AbcH3JWk (ORCPT ); Tue, 30 Aug 2016 05:22:40 -0400 From: Laurent Pinchart To: John Stultz Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Srinivas Kandagatla , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Boris Brezillon , Andy Green , Dave Long , Guodong Xu , Zhangfei Gao , Mark Brown , Lars-Peter Clausen , Jose Abreu , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/4 v2] Audio support for adv7511 hdmi bridge Date: Tue, 30 Aug 2016 12:23 +0300 Message-ID: <3891360.bEMoZb6Wzz@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.20; x86_64; ; ) In-Reply-To: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u7U9Mjps028150 Hi John, Thank you for the patches. On Monday 29 Aug 2016 16:41:32 John Stultz wrote: > This is another swing at getting the adv7511 hdmi bridge > audio support reviewed. > > I've taken the core audio work done by Lars-Peter Clausen, and > adapted by Srinivas Kandagatla and Archit Taneja, and tried to > rework it to use the hdmi-codec sound driver. > > This patchset, along with the i2s driver and dts changes allows > HDMI audio to work on the HiKey board. Where are the dts changes ? > I'd really appreciate any thoughts or feedback. > > New in v2: > * Integrated Srinivas' review feedback > > thanks > -john > > Cc: David Airlie > Cc: Archit Taneja > Cc: Laurent Pinchart > Cc: Wolfram Sang > Cc: Srinivas Kandagatla > Cc: "Ville Syrjälä" > Cc: Boris Brezillon > Cc: Andy Green > Cc: Dave Long > Cc: Guodong Xu > Cc: Zhangfei Gao > Cc: Mark Brown > Cc: Lars-Peter Clausen > Cc: Jose Abreu > Cc: dri-devel@lists.freedesktop.org > > Andy Green (1): > drm/bridge: adv7511: Initialize audio packet on adv7533 > > Archit Taneja (1): > drm/bridge: adv7511: Move the common data structures to header file > > John Stultz (1): > drm/bridge: adv7511: Add Audio support. > > Srinivas Kandagatla (1): > drm/bridge: adv7511: Enable the audio data and clock pads on adv7533 > > drivers/gpu/drm/bridge/adv7511/Kconfig | 1 + > drivers/gpu/drm/bridge/adv7511/Makefile | 2 +- > drivers/gpu/drm/bridge/adv7511/adv7511.h | 13 ++ > drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 199 ++++++++++++++++++++++ > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +- > drivers/gpu/drm/bridge/adv7511/adv7533.c | 23 +++ > 6 files changed, 244 insertions(+), 3 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/adv7511/adv7511_audio.c -- Regards, Laurent Pinchart