All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: linux-mtd@lists.infradead.org, juergen.lachmann@harman.com,
	linux-kernel@vger.kernel.org, thomas.roeder@harman.com
Subject: Re: [PATCH 2/2] ubi: Expose the bitrot interface
Date: Thu, 08 Nov 2018 15:31:53 +0100	[thread overview]
Message-ID: <3899237.k0VKClGc8u@blindfold> (raw)
In-Reply-To: <20181108152642.03178c6c@bbrezillon>

Am Donnerstag, 8. November 2018, 15:26:42 CET schrieb Boris Brezillon:
> On Wed,  7 Nov 2018 23:16:19 +0100
> Richard Weinberger <richard@nod.at> wrote:
> 
> > +/**
> > + * ubi_bitflip_check - Check an eraseblock for bitflips and scrub it if needed.
> > + * @ubi: UBI device description object
> > + * @pnum: the physical eraseblock to schedule
> > + * @force_scrub: force scrubbing if non-zero, schedule erase otherwise
> 
> Are you sure about the "schedule erase otherwise"? I'd say force_scrub
> only influence when the scrub operation is done: either unconditionally
> or depending on the result of ubi_io_read().

True. As often, code and documentation diverged a little.

Thanks,
//richard

      reply	other threads:[~2018-11-08 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 22:16 [PATCH 1/2] ubi: Introduce in_pq() Richard Weinberger
2018-11-07 22:16 ` [PATCH 2/2] ubi: Expose the bitrot interface Richard Weinberger
2018-11-08 14:26   ` Boris Brezillon
2018-11-08 14:31     ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3899237.k0VKClGc8u@blindfold \
    --to=richard@nod.at \
    --cc=boris.brezillon@bootlin.com \
    --cc=juergen.lachmann@harman.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=thomas.roeder@harman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.