All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH v3] tcp: pass back data left in socket after receive
Date: Fri, 29 Apr 2022 21:08:14 -0600	[thread overview]
Message-ID: <38ae32bb-59e5-3e5e-6d22-245e757e428a@kernel.dk> (raw)
In-Reply-To: <20220429191538.713da873@kernel.org>

On 4/29/22 8:15 PM, Jakub Kicinski wrote:
> On Thu, 28 Apr 2022 18:45:06 -0600 Jens Axboe wrote:
>> This is currently done for CMSG_INQ, add an ability to do so via struct
>> msghdr as well and have CMSG_INQ use that too. If the caller sets
>> msghdr->msg_get_inq, then we'll pass back the hint in msghdr->msg_inq.
>>
>> Rearrange struct msghdr a bit so we can add this member while shrinking
>> it at the same time. On a 64-bit build, it was 96 bytes before this
>> change and 88 bytes afterwards.
>>
>> Reviewed-by: Eric Dumazet <edumazet@google.com>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> 
> Commit f94fd25cb0aa ("tcp: pass back data left in socket after
> receive") in net-next now, thanks!

Great, thanks Jakub! I'll base on this for the io_uring change.

-- 
Jens Axboe


      reply	other threads:[~2022-04-30  3:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29  0:45 [PATCH v3] tcp: pass back data left in socket after receive Jens Axboe
2022-04-30  2:15 ` Jakub Kicinski
2022-04-30  3:08   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38ae32bb-59e5-3e5e-6d22-245e757e428a@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.