RE: [PATCH] ASoC: rt721-sdca: Adjust blindwrite flow to fix type detection issue

[Jack Yu <jack.yu@realtek.com>]

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Wednesday, September 30, 2026 1:47 AM
> To: Jack Yu <jack.yu@realtek.com>
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de;
> Flove(HsinFu) <flove@realtek.com>; Oder Chiou <oder_chiou@realtek.com>;
> Shuming [范書銘] <shumingf@realtek.com>; Derek [方德義]
> <derek.fang@realtek.com>
> Subject: Re: [PATCH] ASoC: rt721-sdca: Adjust blindwrite flow to fix type
> detection issue
> 
> On Tue, Sep 29, 2026 at 07:17:09PM +0800, jack.yu@realtek.com wrote:
> > From: Jack Yu <jack.yu@realtek.com>
> >
> > Original blindwrite flow fail to support nokia type detection, but
> > it's works normally in iphone type detection.
> > We adjust the register settings to support both type detection.
> 
> >  static const struct reg_default rt721_sdca_mbq_defaults[] = {
> > +	{ 0x0900006, 0xe000 },
> >  	{ 0x0900007, 0xc004 },
> > +	{ 0x0910000, 0x00a1 },
> > +	{ 0x0910001, 0x1256 },
> > +	{ 0x0910002, 0x0000 },
> > +	{ 0x0910003, 0x0000 },
> > +	{ 0x0c00005, 0xf140 },
> 
> Is that register volatile?
Only 0x0c00005 is the volatile register, I'll modify this in v2 patch.

> 
> >  static void rt721_sdca_jack_detect_handler(struct work_struct *work)
> > {
> 
> > +		if ((rt721->scp_sdca_stat1 & SDW_SCP_SDCA_INT_SDCA_0) &&
> > +			!(rt721->scp_sdca_stat2 & SDW_SCP_SDCA_INT_SDCA_8) &&
> > +			real_JD == 0x1 && rt721->int_cnt == 0 &&
> > +			!rt721->imp_sensing_done && rt721->jack_type != 0) {
> > +			dev_info(&rt721->slave->dev,
> > +				"%s: resume with jack present, reuse jack_type=%d\n",
> > +				__func__, rt721->jack_type);
> 
> Does this do the right thing if the thing plugged into the jack changes over
> suspend (eg, close their laptop, unplug their headset, go home, plug in their
> headphones, open their laptop)?
> 
Thanks for pointing out, I'll address this issue in v2 patch.
> > +		if ((rt721->scp_sdca_stat1 & SDW_SCP_SDCA_INT_SDCA_0) &&
> > +			!(rt721->scp_sdca_stat2 & SDW_SCP_SDCA_INT_SDCA_8) &&
> > +			rt721->int_cnt == 0 && real_JD == 0x1 &&
> > +			!rt721->imp_sensing_done) {
> > +			dev_info(&rt721->slave->dev,
> > +				"%s: BRANCH impedance_sensing (SDCA_0 set, fresh
> pass)\n",
> > +				__func__);
> > +			rt721->imp_sensing_done = true;
> > +			rt721_impedance_sensing(rt721);
> > +			rt721->imp_sensing_ongoing = false;
> > +			return;
> 
> Does rt721_sdca_btn_check_handler() also need updates to reset all the state
> on removal?
Will fix in v2 patch.