From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <dlemoal@kernel.org>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
dm-devel@lists.linux.dev, Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [PATCH v3 2/5] block: Introduce bio_needs_zone_write_plugging()
Date: Wed, 25 Jun 2025 08:48:04 -0700 [thread overview]
Message-ID: <38ddf5f9-80e4-4909-b5cc-cef0ffce19dd@acm.org> (raw)
In-Reply-To: <20250625093327.548866-3-dlemoal@kernel.org>
On 6/25/25 2:33 AM, Damien Le Moal wrote:
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 4806b867e37d..0c61492724d2 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -3169,8 +3169,10 @@ void blk_mq_submit_bio(struct bio *bio)
> if (blk_mq_attempt_bio_merge(q, bio, nr_segs))
> goto queue_exit;
>
> - if (blk_queue_is_zoned(q) && blk_zone_plug_bio(bio, nr_segs))
> - goto queue_exit;
> + if (bio_needs_zone_write_plugging(bio)) {
> + if (blk_zone_plug_bio(bio, nr_segs))
> + goto queue_exit;
> + }
Why nested if-statements instead of keeping "&&"? I prefer "&&".
Thanks,
Bart.
next prev parent reply other threads:[~2025-06-25 15:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 9:33 [PATCH v3 0/5] Fix write operation handling for zoned DM devices Damien Le Moal
2025-06-25 9:33 ` [PATCH v3 1/5] block: Make REQ_OP_ZONE_FINISH a write operation Damien Le Moal
2025-06-25 11:28 ` Christoph Hellwig
2025-06-25 11:42 ` Johannes Thumshirn
2025-06-25 15:44 ` Bart Van Assche
2025-06-25 16:29 ` Bart Van Assche
2025-06-25 23:36 ` Damien Le Moal
2025-06-26 20:29 ` Bart Van Assche
2025-06-25 9:33 ` [PATCH v3 2/5] block: Introduce bio_needs_zone_write_plugging() Damien Le Moal
2025-06-25 11:28 ` Christoph Hellwig
2025-06-25 11:47 ` Johannes Thumshirn
2025-06-25 15:48 ` Bart Van Assche [this message]
2025-06-25 23:38 ` Damien Le Moal
2025-06-26 16:37 ` Bart Van Assche
2025-06-25 9:33 ` [PATCH v3 3/5] dm: Always split write BIOs to zoned device limits Damien Le Moal
2025-06-25 11:49 ` Johannes Thumshirn
2025-06-25 16:30 ` Mikulas Patocka
2025-06-25 16:34 ` Bart Van Assche
2025-06-25 23:41 ` Damien Le Moal
2025-06-25 9:33 ` [PATCH v3 4/5] dm: dm-crypt: Do not partially accept write BIOs with zoned targets Damien Le Moal
2025-06-25 16:31 ` Mikulas Patocka
2025-06-25 16:42 ` Bart Van Assche
2025-06-25 9:33 ` [PATCH v3 5/5] dm: Check for forbidden splitting of zone write operations Damien Le Moal
2025-06-25 16:31 ` Mikulas Patocka
2025-06-25 16:37 ` [PATCH v3 0/5] Fix write operation handling for zoned DM devices Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38ddf5f9-80e4-4909-b5cc-cef0ffce19dd@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.