Re: [Outreachy kernel] [PATCH v2] Convert simple_strtoul to kstrtoul

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Navya,

Thank you for the patch.

On Thursday 19 February 2015 23:04:59 Navya Sri Nizamkari wrote:
> This patch fixes the checkpatch.pl warning:
> simple_strtoul is obsolete, use kstrtoul instead.
> 
> When the string is not converted(parsing error),the strings pointed to by ep
> and parport[n] are the same.This parsing error results in kstrtoul
> returning a non-zero value.
> 
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v2:
>     -Added a descriptive commit message.
> 
>  drivers/staging/media/parport/bw-qcam.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/parport/bw-qcam.c
> b/drivers/staging/media/parport/bw-qcam.c index 67b9da1..1b81244 100644
> --- a/drivers/staging/media/parport/bw-qcam.c
> +++ b/drivers/staging/media/parport/bw-qcam.c
> @@ -1106,10 +1106,8 @@ static int accept_bwqcam(struct parport *port)
>  	if (parport[0] && strncmp(parport[0], "auto", 4) != 0) {
>  		/* user gave parport parameters */
>  		for (n = 0; n < MAX_CAMS && parport[n]; n++) {
> -			char *ep;
>  			unsigned long r;
> -			r = simple_strtoul(parport[n], &ep, 0);
> -			if (ep == parport[n]) {
> +			if (kstrtoul(parport[n],0,&r)) {

It's nice to fix checkpatch warnings, but not if you introduce new ones. If 
you run checkpatch on your patch you should get warnings regarding missing 
spaces after commas. As a general rule, you should always run checkpatch on 
all patches you want to submit for review before sending them to mailing 
lists.

>  				printk(KERN_ERR
>  					"bw-qcam: bad port specifier \"%s\"\n",
>  					parport[n]);

-- 
Regards,

Laurent Pinchart