From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] devtools: add test script for meson builds
Date: Tue, 29 May 2018 12:38:14 +0200 [thread overview]
Message-ID: <3902265.nh2GMnEBpQ@xps> (raw)
In-Reply-To: <20180528132023.GB8752@bricha3-MOBL.ger.corp.intel.com>
28/05/2018 15:20, Bruce Richardson:
> On Mon, May 28, 2018 at 12:26:24PM +0200, Thomas Monjalon wrote:
> > 28/05/2018 11:33, Bruce Richardson:
> > > On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote:
> > > > 25/05/2018 17:18, Bruce Richardson:
> > > > > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > > > > > +load_config () +{ + reset_env + . $(dirname $(readlink -e
> > > > > > $0))/load-devel-config + MESON=${MESON:-meson} +}
> > > > > Why does this need to be done each time?
> > > >
> > > > Because the config could be different for each build (see above).
> > > >
> > > How would it be different, it's the same command called with the same
> > > environment each time?
> >
> > No, the idea is to adapt the environment to the build target. As an
> > example, the dependencies can be different for 32-bit and 64-bit.
> >
> I would hope that dependency detection should solve that, but since you
> already have support for that in existing build script via environment
> vars, I have no objection to leveraging that in the meson scripts. Overall,
> though, I'd prefer to ensure that the detection works so that everyone only
> needs one environment setup in order to get all builds working
> simultaneously.
The dependency detection cannot work if I have dependencies in uncommon
directories.
I think it is important to allow testing compilation with dependencies
which are available but not installed, by providing paths.
next prev parent reply other threads:[~2018-05-29 10:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 12:32 [PATCH] devtools: add test script for meson builds Bruce Richardson
2018-04-24 14:36 ` Bruce Richardson
2018-04-24 14:38 ` Bruce Richardson
2018-05-25 14:51 ` [PATCH v2] " Thomas Monjalon
2018-05-25 15:18 ` Bruce Richardson
2018-05-26 9:32 ` Thomas Monjalon
2018-05-28 9:33 ` Bruce Richardson
2018-05-28 10:26 ` Thomas Monjalon
2018-05-28 13:20 ` Bruce Richardson
2018-05-29 10:38 ` Thomas Monjalon [this message]
2018-05-29 10:59 ` Bruce Richardson
2018-05-26 9:54 ` [PATCH v3] " Thomas Monjalon
2018-05-26 11:21 ` [PATCH v4] " Thomas Monjalon
2018-05-28 9:39 ` Bruce Richardson
2018-05-29 14:42 ` [PATCH v5] " Thomas Monjalon
2018-05-29 14:58 ` Richardson, Bruce
2018-05-29 15:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3902265.nh2GMnEBpQ@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.