From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC PATCH 2/3] drm: bridge: panel: allow override of the bus format Date: Wed, 04 Apr 2018 01:18:35 +0300 Message-ID: <39049661.yQjn2ecPlO@avalon> References: <20180317221525.18534-1-peda@axentia.se> <1986009.iWteaM7My3@avalon> <20180327081601.GJ27746@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180327081601.GJ27746@w540> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jacopo mondi Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Daniel Vetter , Peter Rosin List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKT24gVHVlc2RheSwgMjcgTWFyY2ggMjAxOCAxMToxNjowMSBFRVNUIGphY29w byBtb25kaSB3cm90ZToKPiBPbiBNb24sIE1hciAyNiwgMjAxOCBhdCAxMDowMzozMVBNICswMzAw LCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gT24gU3VuZGF5LCAyNSBNYXJjaCAyMDE4IDE1 OjAxOjExIEVFU1QgUGV0ZXIgUm9zaW4gd3JvdGU6Cj4gPj4gT24gMjAxOC0wMy0yMCAxNDo1Niwg TGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4gT24gU3VuZGF5LCAxOCBNYXJjaCAyMDE4IDAw OjE1OjI0IEVFVCBQZXRlciBSb3NpbiB3cm90ZToKPiA+Pj4+IFVzZWZ1bCBpZiB0aGUgYnJpZGdl IGRvZXMgc29tZSBraW5kIG9mIGNvbnZlcnNpb24gb2YgdGhlIGJ1cyBmb3JtYXQuCj4gPj4+PiAK PiA+Pj4+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+Cj4gPj4+ PiAtLS0KPiA+Pj4+IAo+ID4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcGFuZWwuYyB8IDIy ICsrKysrKysrKysrKysrKysrKysrKy0KPiA+Pj4+ICBpbmNsdWRlL2RybS9kcm1fYnJpZGdlLmgg ICAgICAgfCAgMSArCj4gPj4+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pCj4gPj4+PiAKPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YnJpZGdlL3BhbmVsLmMKPiA+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9wYW5lbC5jIGlu ZGV4IDZkOTlkNGEzYmViMy4uY2NlZjAyODNmZjQxCj4gPj4+PiAxMDA2NDQKPiA+Pj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcGFuZWwuYwo+ID4+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2JyaWRnZS9wYW5lbC5jCj4gPj4+PiBAQCAtMjIsNiArMjIsNyBAQCBzdHJ1Y3QgcGFuZWxf YnJpZGdlIHsKPiA+Pj4+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgY29ubmVjdG9yOwo+ID4+Pj4g IAlzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbDsKPiA+Pj4+ICAJdTMyIGNvbm5lY3Rvcl90eXBlOwo+ ID4+Pj4gKwl1MzIgYnVzX2Zvcm1hdDsKPiA+Pj4+ICB9Owo+ID4+Pj4gIAo+ID4+Pj4gIHN0YXRp YyBpbmxpbmUgc3RydWN0IHBhbmVsX2JyaWRnZSAqCj4gPj4+PiBAQCAtNDAsOCArNDEsMTUgQEAg c3RhdGljIGludCBwYW5lbF9icmlkZ2VfY29ubmVjdG9yX2dldF9tb2RlcyhzdHJ1Y3QKPiA+Pj4+ IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvcikgewo+ID4+Pj4gIAlzdHJ1Y3QgcGFuZWxfYnJpZGdl ICpwYW5lbF9icmlkZ2UgPQo+ID4+Pj4gIAkJZHJtX2Nvbm5lY3Rvcl90b19wYW5lbF9icmlkZ2Uo Y29ubmVjdG9yKTsKPiA+Pj4+ICsJaW50IHJldDsKPiA+Pj4+ICsKPiA+Pj4+ICsJcmV0ID0gZHJt X3BhbmVsX2dldF9tb2RlcyhwYW5lbF9icmlkZ2UtPnBhbmVsKTsKPiA+Pj4+ICsKPiA+Pj4+ICsJ aWYgKHBhbmVsX2JyaWRnZS0+YnVzX2Zvcm1hdCkKPiA+Pj4+ICsJCWRybV9kaXNwbGF5X2luZm9f c2V0X2J1c19mb3JtYXRzKCZjb25uZWN0b3ItPmRpc3BsYXlfaW5mbywKPiA+Pj4+ICsJCQkJCQkg JnBhbmVsX2JyaWRnZS0+YnVzX2Zvcm1hdCwgMSk7Cj4gPj4+IAo+ID4+PiBXaGlsZSBJIGFncmVl IHdpdGggdGhlIHByb2JsZW0gc3RhdGVtZW50IGFuZCwgdG8gc29tZSBleHRlbnQsIHRoZSBEVAo+ ID4+PiBiaW5kaW5ncywgSSBkb24ndCB0aGluayB0aGlzIGlzIHRoZSByaWdodCBpbXBsZW1lbnRh dGlvbi4gWW91J3ZlCj4gPj4+IGNvcnJlY3RseSBub3RlZCB0aGF0IGRpc3BsYXkgY29udHJvbGxl ciBzaG91bGRuJ3QgYmxpbmRseSB1c2UgdGhlCj4gPj4+IGZvcm1hdHMgcmVwb3J0ZWQgYnkgdGhl IHBhbmVsIHRocm91Z2ggdGhlIGNvbm5lY3RvciBmb3JtYXRzLCBhbmQgdGhhdAo+ID4+PiBoYWNr aW5nIHRoZSBwYW5lbCBkcml2ZXIgdG8gb3ZlcnJpZGUgdGhlIGZvcm1hdHMgaXNuJ3QgYSBnb29k IGlkZWEsIHNvCj4gPj4+IEkgd291bGRuJ3Qgb3ZlcnJpZGUgdGhlIGZvcm1hdHMgcmVwb3J0ZWQg YnkgdGhlIGNvbm5lY3Rvci4gSSB3b3VsZAo+ID4+PiBpbnN0ZWFkIGV4dGVuZCB0aGUgZHJtX2Jy aWRnZSBBUEkgdG8gcmVwb3J0IGZvcm1hdHMgYXQgYnJpZGdlIGlucHV0cy4KPiA+Pj4gVGhpcyB3 b3VsZCBiZSBtb3JlIGdlbmVyaWMgYW5kIGFsbG93IGVhY2ggYnJpZGdlIHRvIGNvbmZpZ3VyZSBp dHNlbGYKPiA+Pj4gYWNjb3JkaW5nIHRvIHRoZSBuZXh0IGJyaWRnZSBpbiB0aGUgY2hhaW4uCj4g Pj4+IAo+ID4+PiBJJ20gbm90IHN1cmUgd2hldGhlciB0aGlzIEFQSSBleHRlbnNpb24gc2hvdWxk IGJlIGluIHRoZSBmb3JtIG9mIGEgbmV3Cj4gPj4+IGJyaWRnZSBmdW5jdGlvbiwgb3IgaWYgdGhl IGZvcm1hdHMgc2hvdWxkIGJlIHN0b3JlZCBpbiB0aGUgZHJtX2JyaWRnZQo+ID4+PiBzdHJ1Y3R1 cmUgZGlyZWN0bHkgYXMgZG9uZSBmb3IgY29ubmVjdG9ycyBpbiB0aGUgZGlzcGxheSBpbmZvCj4g Pj4+IHN0cnVjdHVyZS4gSSdtIHRlbXB0ZWQgYnkgdGhlIGZvcm1lciwgYnV0IEknbSBvcGVuIHRv IGRpc2N1c3Npb25zLgo+ID4+IAo+ID4+IE9rLCBJIGNhbiBsb29rIGludG8gdGhhdCwgYnV0IGxl dCBtZSBjaGVjayBpZiBJIGdvdCB0aGlzIHJpZ2h0LiBGcm9tIHRoZQo+ID4+IHZlcnkgbGl0dGxl IG9mIHRoZSBjb2RlIHRoYXQgSSBoYXZlIGxvb2tlZCBhdCwgSSBoYXZlIGdhdGhlcmVkIHRoYXQK PiA+PiBkaXNwbGF5IGNvbnRyb2xsZXJzIGhhbmRsZSBicmlkZ2VzIGV4cGxpY2l0bHksIHJpZ2h0 Pwo+ID4gCj4gPiBUaGF0J3MgY29ycmVjdCwgeWVzLiBPciwgcmF0aGVyLCB0aGV5IGhhbmRsZSB0 aGUgZmlyc3QgYnJpZGdlIGluIHRoZQo+ID4gY2hhaW4sIGFuZCB0aGVuIG90aGVyIGJyaWRnZXMg YXJlIGhhbmRsZWQgcmVjdXJzaXZlbHkuCj4gPiAKPiA+PiBJZiBzbywgYnkgZXh0ZW5kaW5nIHRo ZSBicmlkZ2UgKHdpdGggZWl0aGVyIGEgbmV3IGZ1bmN0aW9uIG9yIG5ldyBkYXRhKQo+ID4+IHlv dSBpbXBvc2UgY2hhbmdlcyB0byBhbGwgZGlzcGxheSBjb250cm9sbGVycyB3YW50aW5nIHRvIGhh bmRsZSB0aGlzIG5ldwo+ID4+IGJyaWRnZSBpbnB1dC1mb3JtYXQuIElmIHNvLCBJIGFzc3VtZSBJ IGNhbiBsZWF2ZSBvdXQgdGhlIGNoYW5nZXMgdG8gYWxsCj4gPj4gZGlzcGxheSBjb250cm9sbGVy cyB0aGF0IEkgZG8gbm90IGNhcmUgYWJvdXQuIENvcnJlY3Q/Cj4gPiAKPiA+IFRoYXQncyBjb3Jy ZWN0Lgo+ID4gCj4gPj4gQWxzbywgZG9uJ3QgaG9sZCB5b3VyIGJyZWF0aCB3YWl0aW5nIGZvciBh IHYyLCBidXQgSSdsbCB0cnkgdG8gZ2V0IHRvIGl0Cj4gPj4gOi0pCj4gPiAKPiA+IEkgd29uJ3Qg aG9sZCBteSBicmVhdGgsIGJ1dCBKYWNvcG8gbWlnaHQgOi0pIEhlIGhhcyBhIHNpbWlsYXIgaXNz dWUgdG8KPiA+IHNvbHZlIChyZXBvcnRpbmcgdGhlIExWRFMgbW9kZXMgc3VwcG9ydGVkIGJ5IHRo ZSBicmlkZ2UpLgo+IAo+IEkgd2FzIG5vdCA6KSBJIGp1bXBlZCBsYXRlIG9uIHRoaXMsIGFzIEkg cmVzdGFydGVkIHRoZSBEUk0gYnJpZGdlIHdvcmsKPiB5ZXN0ZXJkYXkuIFBldGVyLCBjYW4gSSBz dW1tYXJpemUgeW91IG15IGN1cnJlbnQgdXNlIGNhc2U/ICh3aGljaCBpcwo+IHF1aXRlIHNpbWls YXIgdG8geW91cnMgYWN0dWFsbHkpCj4gCj4gQXQgdGhlIFItQ2FyIERVIChEaXNwbGF5IFVuaXQp IG91dHB1dCwgd2UgaGF2ZSBhbiBMVkRTIGVuY29kZXIKPiBjb25uZWN0ZWQgdG8gYSAndHJhbnNw YXJlbnQnIExWRFMgYnJpZGdlIHRoYXQgY29udmVydHMgdGhlIGlucHV0IExWRFMKPiBzdHJlYW0g aW50byBkaWdpdGFsIFJHQiBvdXRwdXQgdG8gYmUgdGhlbiBIRE1JIGVuY29kZWQgYnkgYW5vdGhl cgo+IGNvbXBvbmVudC4KPiAKPiBUaGUgJ3RyYW5zcGFyZW50IExWRFMgZGVjb2RlcicsIGZvciB3 aGljaCBJJ20gbm93IHdyaXRpbmcgYSBkcml2ZXIsCj4gc2hvdWxkIHJlcG9ydCB3aGF0IHBpeGVs IGJ1cyBmb3JtYXQgaXQgYWNjZXB0cyBhcyBpbnB1dCBhcyB0aGUgRFUgTFZEUwo+IGVuY29kZXIg Y2FuIG91dHB1dCBhbiBMVkRTIHN0cmVhbSB3aXRoIHNldmVyYWwgZGlmZmVyZW50IGNvbXBvbmVu dCBvcmRlcmluZwo+IHNjaGVtZXMuIEkgd2FzIGFib3V0IHRvIGNvbWUgdXAgd2l0aCBhIHByb3Bv c2FsIGxhc3Qgd2VlayBidXQgeW91IGJlYXQKPiBtZSBhdCB0aW1lLCBzbyBJJ20gaGFwcHkgdG8g YmFzZSBteSB3b3JrIG9uIHdoYXQgY29tZXMgb3V0IGZyb20gdGhpcwo+IHNlcmllcy4KPiAKPiAt LS0tIExhdXJlbnQ6IE9uIHRoZSBUSEM2M0xWRCBkcml2ZXIKPiBMYXVyZW50OiBhdCB0aGUgc2Ft ZSB0aW1lIEkgd291bGQgbm90IGJsb2NrIHRoZSBUSEM2M0xWRDEwMjQgZHJpdmVyLiBJCj4gY2Fu IGV4dGVuZCBiaW5kaW5ncyB0byBpbmNsdWRlIHRoZSAibW9kZSBtYXAiIGNvbmZpZ3VyYXRpb24g cHJvcGVydHksCj4gYW5kIHNxdWFzaCBteSBFYWdsZSBEVFMgcGF0Y2ggb24gdG9wIG9mIE5pa2xh cycgb25lLiBUaGVuIG1ha2UgdGhlIG5ld2x5Cj4gaW50cm9kdWNlZCBkcml2ZXIgdXNlIHdoYXRl dmVyIEFQSSBjb21lcyBvdXQgZnJvbSB0aGlzIHNlcmllcyB3aXRoIGFuCj4gaW5jcmVtZW50YWwg cGF0Y2guIERvZXMgdGhpcyB3b3JrIGZvciB5b3U/IEl0IGlzIHRydWUsIHRob3VnaCwgdGhhdAo+ IHdlJ3JlIGFueXdheSBsYXRlIGZvciB2NC4xNyBhbmQgSSBjb3VsZCBzZW5kIG9uZSBzaW5nbGUg c2VyaWVzIGJhc2VkCj4gb24gc29tZSBmdXR1cmUgdmVyc2lvbiBvZiB0aGlzIGFuZCB0aGF0IGlu Y2x1ZGVzIGFsbCAoYnJpZGdlIGRyaXZlcgo+IGFuZCBiaW5kaW5ncywgRFUgTFZEUyBjaGFuZ2Vz IGFuZCBFYWdsZSBEVFMpLCBidXQgSSBmZWVsIGl0J3MgZWFzaWVyCj4gaWYgd2UgZ290IHRoZSBi cmlkZ2UgZHJpdmVyIGFjY2VwdGVkIGZpcnN0LCBhbmQgdGhlbiBkZXZlbG9wIG9uIHRvcCBvZgo+ IHRoYXQuCgpJJ20gZmluZSB3aXRoIGJvdGggb3B0aW9ucywgeW91IGNhbiBwaWNrIHRoZSBvbmUg dGhhdCB3aWxsIG1hdGNoIHdoYXQgaXMgcmVhZHkgCmluIHVwc3RyZWFtIGJ5IHRoZSB0aW1lIHlv dSBnZXQgdG8gc3VibWl0IHRoZSBwYXRjaGVzLgoKPiA+Pj4+IC0JcmV0dXJuIGRybV9wYW5lbF9n ZXRfbW9kZXMocGFuZWxfYnJpZGdlLT5wYW5lbCk7Cj4gPj4+PiArCXJldHVybiByZXQ7Cj4gPj4+ PiAgfQo+ID4+Pj4gIAo+ID4+Pj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9o ZWxwZXJfZnVuY3MKPiA+Pj4+IEBAIC0yMDMsNiArMjExLDE4IEBAIHZvaWQgZHJtX3BhbmVsX2Jy aWRnZV9yZW1vdmUoc3RydWN0IGRybV9icmlkZ2UKPiA+Pj4+ICpicmlkZ2UpCj4gPj4+PiAgfQo+ ID4+Pj4gIEVYUE9SVF9TWU1CT0woZHJtX3BhbmVsX2JyaWRnZV9yZW1vdmUpOwo+ID4+Pj4gCj4g Pj4+PiArdm9pZCBkcm1fcGFuZWxfYnJpZGdlX3NldF9idXNfZm9ybWF0KHN0cnVjdCBkcm1fYnJp ZGdlICpicmlkZ2UsIHUzMgo+ID4+Pj4gYnVzX2Zvcm1hdCkKPiA+Pj4+ICt7Cj4gPj4+PiArCXN0 cnVjdCBwYW5lbF9icmlkZ2UgKnBhbmVsX2JyaWRnZTsKPiA+Pj4+ICsKPiA+Pj4+ICsJaWYgKCFi cmlkZ2UpCj4gPj4+PiArCQlyZXR1cm47Cj4gPj4+PiArCj4gPj4+PiArCXBhbmVsX2JyaWRnZSA9 IGRybV9icmlkZ2VfdG9fcGFuZWxfYnJpZGdlKGJyaWRnZSk7Cj4gPj4+PiArCXBhbmVsX2JyaWRn ZS0+YnVzX2Zvcm1hdCA9IGJ1c19mb3JtYXQ7Cj4gPj4+PiArfQo+ID4+Pj4gK0VYUE9SVF9TWU1C T0woZHJtX3BhbmVsX2JyaWRnZV9zZXRfYnVzX2Zvcm1hdCk7Cj4gPj4+PiArCj4gPj4+PiAgc3Rh dGljIHZvaWQgZGV2bV9kcm1fcGFuZWxfYnJpZGdlX3JlbGVhc2Uoc3RydWN0IGRldmljZSAqZGV2 LCB2b2lkCj4gPj4+PiAgKnJlcykKPiA+Pj4+ICB7Cj4gPj4+PiAgCXN0cnVjdCBkcm1fYnJpZGdl ICoqYnJpZGdlID0gcmVzOwo+ID4+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9icmlk Z2UuaCBiL2luY2x1ZGUvZHJtL2RybV9icmlkZ2UuaAo+ID4+Pj4gaW5kZXggNjgyZDAxYmE5MjBj Li44MTkwM2I5MmYxODcgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fYnJpZGdl LmgKPiA+Pj4+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9icmlkZ2UuaAo+ID4+Pj4gQEAgLTI2OCw2 ICsyNjgsNyBAQCB2b2lkIGRybV9icmlkZ2VfZW5hYmxlKHN0cnVjdCBkcm1fYnJpZGdlCj4gPj4+ PiAqYnJpZGdlKTsKPiA+Pj4+ICBzdHJ1Y3QgZHJtX2JyaWRnZSAqZHJtX3BhbmVsX2JyaWRnZV9h ZGQoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwsCj4gPj4+PiAgCQkJCQl1MzIgY29ubmVjdG9yX3R5 cGUpOwo+ID4+Pj4gIHZvaWQgZHJtX3BhbmVsX2JyaWRnZV9yZW1vdmUoc3RydWN0IGRybV9icmlk Z2UgKmJyaWRnZSk7Cj4gPj4+PiArdm9pZCBkcm1fcGFuZWxfYnJpZGdlX3NldF9idXNfZm9ybWF0 KHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsIHUzMgo+ID4+Pj4gYnVzX2Zvcm1hdCk7Cj4gPj4+ PiBzdHJ1Y3QgZHJtX2JyaWRnZSAqZGV2bV9kcm1fcGFuZWxfYnJpZGdlX2FkZChzdHJ1Y3QgZGV2 aWNlICpkZXYsCj4gPj4+PiAgCQkJCQkgICAgIHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsLAo+ID4+ Pj4gIAkJCQkJICAgICB1MzIgY29ubmVjdG9yX3R5cGUpOwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50 IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688AbeDCWS2 (ORCPT ); Tue, 3 Apr 2018 18:18:28 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:42776 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457AbeDCWS1 (ORCPT ); Tue, 3 Apr 2018 18:18:27 -0400 From: Laurent Pinchart To: jacopo mondi Cc: Peter Rosin , Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Daniel Vetter Subject: Re: [RFC PATCH 2/3] drm: bridge: panel: allow override of the bus format Date: Wed, 04 Apr 2018 01:18:35 +0300 Message-ID: <39049661.yQjn2ecPlO@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180327081601.GJ27746@w540> References: <20180317221525.18534-1-peda@axentia.se> <1986009.iWteaM7My3@avalon> <20180327081601.GJ27746@w540> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Tuesday, 27 March 2018 11:16:01 EEST jacopo mondi wrote: > On Mon, Mar 26, 2018 at 10:03:31PM +0300, Laurent Pinchart wrote: > > On Sunday, 25 March 2018 15:01:11 EEST Peter Rosin wrote: > >> On 2018-03-20 14:56, Laurent Pinchart wrote: > >>> On Sunday, 18 March 2018 00:15:24 EET Peter Rosin wrote: > >>>> Useful if the bridge does some kind of conversion of the bus format. > >>>> > >>>> Signed-off-by: Peter Rosin > >>>> --- > >>>> > >>>> drivers/gpu/drm/bridge/panel.c | 22 +++++++++++++++++++++- > >>>> include/drm/drm_bridge.h | 1 + > >>>> 2 files changed, 22 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/gpu/drm/bridge/panel.c > >>>> b/drivers/gpu/drm/bridge/panel.c index 6d99d4a3beb3..ccef0283ff41 > >>>> 100644 > >>>> --- a/drivers/gpu/drm/bridge/panel.c > >>>> +++ b/drivers/gpu/drm/bridge/panel.c > >>>> @@ -22,6 +22,7 @@ struct panel_bridge { > >>>> struct drm_connector connector; > >>>> struct drm_panel *panel; > >>>> u32 connector_type; > >>>> + u32 bus_format; > >>>> }; > >>>> > >>>> static inline struct panel_bridge * > >>>> @@ -40,8 +41,15 @@ static int panel_bridge_connector_get_modes(struct > >>>> drm_connector *connector) { > >>>> struct panel_bridge *panel_bridge = > >>>> drm_connector_to_panel_bridge(connector); > >>>> + int ret; > >>>> + > >>>> + ret = drm_panel_get_modes(panel_bridge->panel); > >>>> + > >>>> + if (panel_bridge->bus_format) > >>>> + drm_display_info_set_bus_formats(&connector->display_info, > >>>> + &panel_bridge->bus_format, 1); > >>> > >>> While I agree with the problem statement and, to some extent, the DT > >>> bindings, I don't think this is the right implementation. You've > >>> correctly noted that display controller shouldn't blindly use the > >>> formats reported by the panel through the connector formats, and that > >>> hacking the panel driver to override the formats isn't a good idea, so > >>> I wouldn't override the formats reported by the connector. I would > >>> instead extend the drm_bridge API to report formats at bridge inputs. > >>> This would be more generic and allow each bridge to configure itself > >>> according to the next bridge in the chain. > >>> > >>> I'm not sure whether this API extension should be in the form of a new > >>> bridge function, or if the formats should be stored in the drm_bridge > >>> structure directly as done for connectors in the display info > >>> structure. I'm tempted by the former, but I'm open to discussions. > >> > >> Ok, I can look into that, but let me check if I got this right. From the > >> very little of the code that I have looked at, I have gathered that > >> display controllers handle bridges explicitly, right? > > > > That's correct, yes. Or, rather, they handle the first bridge in the > > chain, and then other bridges are handled recursively. > > > >> If so, by extending the bridge (with either a new function or new data) > >> you impose changes to all display controllers wanting to handle this new > >> bridge input-format. If so, I assume I can leave out the changes to all > >> display controllers that I do not care about. Correct? > > > > That's correct. > > > >> Also, don't hold your breath waiting for a v2, but I'll try to get to it > >> :-) > > > > I won't hold my breath, but Jacopo might :-) He has a similar issue to > > solve (reporting the LVDS modes supported by the bridge). > > I was not :) I jumped late on this, as I restarted the DRM bridge work > yesterday. Peter, can I summarize you my current use case? (which is > quite similar to yours actually) > > At the R-Car DU (Display Unit) output, we have an LVDS encoder > connected to a 'transparent' LVDS bridge that converts the input LVDS > stream into digital RGB output to be then HDMI encoded by another > component. > > The 'transparent LVDS decoder', for which I'm now writing a driver, > should report what pixel bus format it accepts as input as the DU LVDS > encoder can output an LVDS stream with several different component ordering > schemes. I was about to come up with a proposal last week but you beat > me at time, so I'm happy to base my work on what comes out from this > series. > > ---- Laurent: On the THC63LVD driver > Laurent: at the same time I would not block the THC63LVD1024 driver. I > can extend bindings to include the "mode map" configuration property, > and squash my Eagle DTS patch on top of Niklas' one. Then make the newly > introduced driver use whatever API comes out from this series with an > incremental patch. Does this work for you? It is true, though, that > we're anyway late for v4.17 and I could send one single series based > on some future version of this and that includes all (bridge driver > and bindings, DU LVDS changes and Eagle DTS), but I feel it's easier > if we got the bridge driver accepted first, and then develop on top of > that. I'm fine with both options, you can pick the one that will match what is ready in upstream by the time you get to submit the patches. > >>>> - return drm_panel_get_modes(panel_bridge->panel); > >>>> + return ret; > >>>> } > >>>> > >>>> static const struct drm_connector_helper_funcs > >>>> @@ -203,6 +211,18 @@ void drm_panel_bridge_remove(struct drm_bridge > >>>> *bridge) > >>>> } > >>>> EXPORT_SYMBOL(drm_panel_bridge_remove); > >>>> > >>>> +void drm_panel_bridge_set_bus_format(struct drm_bridge *bridge, u32 > >>>> bus_format) > >>>> +{ > >>>> + struct panel_bridge *panel_bridge; > >>>> + > >>>> + if (!bridge) > >>>> + return; > >>>> + > >>>> + panel_bridge = drm_bridge_to_panel_bridge(bridge); > >>>> + panel_bridge->bus_format = bus_format; > >>>> +} > >>>> +EXPORT_SYMBOL(drm_panel_bridge_set_bus_format); > >>>> + > >>>> static void devm_drm_panel_bridge_release(struct device *dev, void > >>>> *res) > >>>> { > >>>> struct drm_bridge **bridge = res; > >>>> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > >>>> index 682d01ba920c..81903b92f187 100644 > >>>> --- a/include/drm/drm_bridge.h > >>>> +++ b/include/drm/drm_bridge.h > >>>> @@ -268,6 +268,7 @@ void drm_bridge_enable(struct drm_bridge > >>>> *bridge); > >>>> struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel, > >>>> u32 connector_type); > >>>> void drm_panel_bridge_remove(struct drm_bridge *bridge); > >>>> +void drm_panel_bridge_set_bus_format(struct drm_bridge *bridge, u32 > >>>> bus_format); > >>>> struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev, > >>>> struct drm_panel *panel, > >>>> u32 connector_type); -- Regards, Laurent Pinchart