Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF

[Jan Stancek <jstancek@redhat.com>]

----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: ltp-list@lists.sourceforge.net
> Sent: Thursday, 4 December, 2014 11:17:41 AM
> Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
> 
> Hi!
> > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > ---
> >  testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > index 9fb4c98..28559d3 100644
> > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> >  	int i;
> >  	int entries;
> >  
> > -	initgroups("root", 0);
> > -
> >  	if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> >  		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> >  
> > @@ -183,6 +181,9 @@ static void setup(void)

I'd add tst_require_root() to setup, since setgroups() requires CAP_SETGID.

> >  	tst_sig(FORK, DEF_HANDLER, cleanup);
> >  
> >  	TEST_PAUSE;
> > +
> > +	GID_T init_gidset[3] = {0, 1, 2};
> 
> This should be gid_t instead of GID_T. The uppercase prototypes are for
> raw syscalls only. The setgroups() you call is glibc wrapper instead.
> 
> > +	setgroups(3, init_gidset);
> 
> Otherwise it looks good to me.

To me as well.

Regards,
Jan

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list