All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, "Burakov,
	Anatoly" <anatoly.burakov@intel.com>,
	ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1 2/4] test/power: add turbo mode to freq check function
Date: Wed, 12 May 2021 17:34:59 +0200	[thread overview]
Message-ID: <3917343.xMDbZIhCeM@thomas> (raw)
In-Reply-To: <e3fe702b-b003-95ec-e156-39bdc4e39d20@intel.com>

22/04/2021 18:13, Burakov, Anatoly:
> On 22-Apr-21 3:40 PM, David Hunt wrote:
> > --- a/app/test/test_power_cpufreq.c
> > +++ b/app/test/test_power_cpufreq.c
> > @@ -48,7 +48,7 @@ static uint32_t total_freq_num;
> >   static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX];
> >   
> >   static int
> > -check_cur_freq(unsigned lcore_id, uint32_t idx)
> > +check_cur_freq(unsigned int lcore_id, uint32_t idx, int turbo)
> 
> Nitpicking, but stdbool exists :) it would be nice to use bool type for 
> bool variables, not int.

Dave, I think you missed this comment.





  reply	other threads:[~2021-05-12 15:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 14:40 [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency David Hunt
2021-04-22 14:40 ` [dpdk-dev] [PATCH v1 2/4] test/power: add turbo mode to freq check function David Hunt
2021-04-22 16:13   ` Burakov, Anatoly
2021-05-12 15:34     ` Thomas Monjalon [this message]
2021-05-12 16:38       ` [dpdk-dev] [dpdk-stable] " David Hunt
2021-04-22 14:40 ` [dpdk-dev] [PATCH v1 3/4] test/power: fix low freq test when turbo enabled David Hunt
2021-04-22 14:40 ` [dpdk-dev] [PATCH v1 4/4] test/power: fix turbo test David Hunt
2021-04-29 10:34 ` [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency Pattan, Reshma
2021-05-11 13:27   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-11 14:41   ` [dpdk-dev] " David Hunt
2021-05-11 14:46     ` Pattan, Reshma
2021-05-12 16:32 ` [dpdk-dev] [PATCH v2 " David Hunt
2021-05-12 16:32   ` [dpdk-dev] [PATCH v2 2/4] test/power: add turbo mode to freq check function David Hunt
2021-05-12 16:32   ` [dpdk-dev] [PATCH v2 3/4] test/power: fix low freq test when turbo enabled David Hunt
2021-05-12 16:32   ` [dpdk-dev] [PATCH v2 4/4] test/power: fix turbo test David Hunt
2021-05-12 20:05     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3917343.xMDbZIhCeM@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.