From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 0/2] cryptodev API changes
Date: Fri, 04 Mar 2016 18:45:31 +0100
Message-ID: <3919673.VtXZRcbfcO@xps13>
References: <1456764731-27168-1-git-send-email-declan.doherty@intel.com>
 <2831187.Fjk3A3necn@xps13>
 <348A99DA5F5B7549AA880327E580B43588F892F0@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Trahe, Fiona" <fiona.trahe@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 00A20F72
 for <dev@dpdk.org>; Fri,  4 Mar 2016 18:47:08 +0100 (CET)
Received: by mail-wm0-f42.google.com with SMTP id n186so1310976wmn.1
 for <dev@dpdk.org>; Fri, 04 Mar 2016 09:47:08 -0800 (PST)
In-Reply-To: <348A99DA5F5B7549AA880327E580B43588F892F0@IRSMSX101.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-04 17:43, Trahe, Fiona:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2016-03-04 17:17, Fiona Trahe:
> > > This patch set separates the symmetric crypto operations from generic
> > operations and then modifies the cryptodev burst API to accept bursts of
> > rte_crypto_op rather than rte_mbufs.
> > >
> > > V5:
> > > - updates .map file
> > > - removes EXPERIMENTAL label from rte_cryptodev.h
> > 
> > Why do you want to remove the experimental label?
> 
> Declan had already removed from the MAINTAINERS file and other places in previous  patches. 
> This one was just forgotten as far as we know, though as Declan is out we can't confirm with him. 
> Do you think we should keep the label ?

I cannot really decide because it's hard to understand the improvements in
a such big patch. It would be easier if the changes were split in several
steps.
Maybe the last step (last patch) would be to remove the flag. Having it in
a separate patch would give the opportunity to detail the reason of the
removal in the commit message.