From: Leo Li <sunpeng.li-5C7GfCeVMHo@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Cc: alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
harry.wentland-5C7GfCeVMHo@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/display: Fix BUG_ON during CRTC atomic check update
Date: Mon, 28 May 2018 12:05:49 -0400 [thread overview]
Message-ID: <391ca9da-66dc-e902-1ef4-e2266c6f95cb@amd.com> (raw)
In-Reply-To: <7be152e0-18c5-22f6-b80a-87e856effff9-otUistvHUpPR7s880joybQ@public.gmane.org>
On 2018-05-28 11:20 AM, Michel Dänzer wrote:
> On 2018-05-28 05:06 PM, sunpeng.li@amd.com wrote:
>> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>
>>
>> For cases where the CRTC is inactive (DPMS off), where a modeset is not
>> required, yet the CRTC is still in the atomic state, we should not
>> attempt to update anything on it.
>>
>> Previously, we were relying on the modereset_required() helper to check
>
> This should say "modeset_required()", right?
>
modereset_required() here refers to an amdgpu_dm specific helper, which
was previously being used. It essentially returns true if the CRTC is
*being* disabled or made inactive, not if it's currently disabled or
inactive.
>
>> the above condition. However, the function returns false immediatly if
>
> "immediately" (missing "e") >
>> a modeset is not required, ignoring the CRTC's enable/active state
>> flags. The correct way to filter is by looking at these flags instead.
>>
>> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Please add the following tags to the commit log:
>
> Fixes: e277adc5a06c "drm/amd/display: Hookup color management functions"
> Tested-by: Michel Dänzer <michel.daenzer@amd.com>
>
Will do.
Leo
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-05-28 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 15:06 [PATCH] drm/amd/display: Fix BUG_ON during CRTC atomic check update sunpeng.li-5C7GfCeVMHo
[not found] ` <1527520003-1224-1-git-send-email-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2018-05-28 15:20 ` Michel Dänzer
[not found] ` <7be152e0-18c5-22f6-b80a-87e856effff9-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-05-28 16:05 ` Leo Li [this message]
2018-05-28 18:00 ` [PATCH v2] " sunpeng.li-5C7GfCeVMHo
[not found] ` <1527530423-14855-1-git-send-email-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2018-05-29 7:55 ` Michel Dänzer
2018-05-29 13:51 ` [PATCH v3] " sunpeng.li-5C7GfCeVMHo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=391ca9da-66dc-e902-1ef4-e2266c6f95cb@amd.com \
--to=sunpeng.li-5c7gfcevmho@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=harry.wentland-5C7GfCeVMHo@public.gmane.org \
--cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.