From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4] igb_uio: fix possible mmap failure for Linux >= v4.5
Date: Sun, 10 Jul 2016 15:58:19 +0200 [thread overview]
Message-ID: <3923466.ri2s8GbSSX@xps13> (raw)
In-Reply-To: <1467730852-12040-1-git-send-email-ferruh.yigit@intel.com>
2016-07-05 16:00, Ferruh Yigit:
> mmap the iomem range of the PCI device fails for kernels that
> enabled CONFIG_IO_STRICT_DEVMEM option:
>
> EAL: pci_map_resource():
> cannot mmap(39, 0x7f1c51800000, 0x100000, 0x0):
> Invalid argument (0xffffffffffffffff)
>
> CONFIG_IO_STRICT_DEVMEM is introduced in Linux v4.5 and not enabled
> by default:
> Linux commit: 90a545e restrict /dev/mem to idle io memory ranges
>
> As a workaround igb_uio can stop reserving PCI memory resources, from
> kernel point of view iomem region looks like idle and mmap works
> again. This matches uio_pci_generic usage.
>
> With this update device iomem range is not protected against any
> other kernel drivers or userspace access. But this shouldn't
> be a problem for dpdk usage module since purpose of the igb_uio
> module is to provide userspace access.
>
> Fixes: af75078fece3 ("first public release")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
I suggested to apply it in RC3 but we have no comments.
That's why it is part of RC2.
next prev parent reply other threads:[~2016-07-10 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 10:21 Issue with igb_uio in Fedora 24 Mcnamara, John
2016-07-01 10:53 ` Ferruh Yigit
2016-07-01 11:35 ` [PATCH] igb_uio: fix mmap failure Ferruh Yigit
2016-07-01 12:47 ` Thomas Monjalon
2016-07-01 14:39 ` Ferruh Yigit
2016-07-01 14:54 ` Thomas Monjalon
2016-07-01 15:07 ` [PATCH v2] igb_uio: fix possible mmap failure for Linux > v4.3 Ferruh Yigit
2016-07-01 15:52 ` De Lara Guarch, Pablo
2016-07-01 15:54 ` Ferruh Yigit
2016-07-01 15:59 ` [PATCH v3] igb_uio: fix possible mmap failure for Linux >= v4.5 Ferruh Yigit
2016-07-05 15:00 ` [PATCH v4] " Ferruh Yigit
2016-07-10 13:58 ` Thomas Monjalon [this message]
2016-07-02 0:12 ` Issue with igb_uio in Fedora 24 De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3923466.ri2s8GbSSX@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.