From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
To: jbarnes@virtuousgeek.org
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
willy@linux.intel.com
Subject: [patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses
Date: Mon, 28 Apr 2008 09:33:27 -0700 (PDT) [thread overview]
Message-ID: <392740.53131.qm@web52007.mail.re2.yahoo.com> (raw)
From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Fix an incorrect suggestion to pass NULL to pci_alloc_consistent
for PCI like buses where devices don't have struct pci_dev (like ISA, EISA).
Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
---
This patch is to be applied on top of
[patch v3] doc: DMA-mapping.txt has undeclared variables [Bug 10397]
--- linux-2.6/Documentation/DMA-mapping.txt 2008-04-28 19:09:36.124693500 +0300
+++ linux/Documentation/DMA-mapping.txt 2008-04-28 19:17:07.711024500 +0300
@@ -317,9 +317,9 @@ you should do:
cpu_addr = pci_alloc_consistent(pdev, size, &dma_handle);
-where pdev is a struct pci_dev *. You should pass NULL for PCI like buses
-where devices don't have struct pci_dev (like ISA, EISA). This may be
-called in interrupt context.
+where pdev is a struct pci_dev *. This may be called in interrupt context.
+You should use dma_alloc_coherent (see DMA-API.txt) for buses
+where devices don't have struct pci_dev (like ISA, EISA).
This argument is needed because the DMA translations may be bus
specific (and often is private to the bus which the device is attached
____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
next reply other threads:[~2008-04-28 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 16:33 Matti Linnanvuori [this message]
2008-04-28 17:03 ` [patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses Matthew Wilcox
2008-04-28 17:09 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=392740.53131.qm@web52007.mail.re2.yahoo.com \
--to=mattilinnanvuori@yahoo.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.