From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Roger Quadros <rogerq@ti.com>
Cc: balbi@ti.com, bcousson@baylibre.com, tony@atomide.com,
balajitk@ti.com, kishon@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 09/15] ata: ti_sata: Add Texas Instruments SATA Wrapper driver
Date: Wed, 25 Sep 2013 14:49:56 +0200 [thread overview]
Message-ID: <3930265.gHe05HETI5@amdc1032> (raw)
In-Reply-To: <5608096.0pgFIteLqQ@amdc1032>
On Wednesday, September 25, 2013 02:37:19 PM Bartlomiej Zolnierkiewicz wrote:
[...]
> > +#ifdef CONFIG_PM
> > +
> > +static int ti_sata_resume(struct device *dev)
> > +{
> > + pm_runtime_disable(dev);
> > + pm_runtime_set_active(dev);
> > + pm_runtime_enable(dev);
>
> This doesn't look like a correct ->resume method:
> * it shouldn't touch runtime PM at all
> * for each ->resume method there should be a corresponding ->suspend method
>
> Moreover this whole wrapper driver seems strange, why not just add a proper
> runtime PM support to ahci_platform driver instead?
Hmm, even this shouldn't be needed as this wrapper driver doesn't have
->runtime_suspend and ->runtime resume methods.
What exactly is the purpose of the existence of this wrapper driver?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 09/15] ata: ti_sata: Add Texas Instruments SATA Wrapper driver
Date: Wed, 25 Sep 2013 14:49:56 +0200 [thread overview]
Message-ID: <3930265.gHe05HETI5@amdc1032> (raw)
In-Reply-To: <5608096.0pgFIteLqQ@amdc1032>
On Wednesday, September 25, 2013 02:37:19 PM Bartlomiej Zolnierkiewicz wrote:
[...]
> > +#ifdef CONFIG_PM
> > +
> > +static int ti_sata_resume(struct device *dev)
> > +{
> > + pm_runtime_disable(dev);
> > + pm_runtime_set_active(dev);
> > + pm_runtime_enable(dev);
>
> This doesn't look like a correct ->resume method:
> * it shouldn't touch runtime PM at all
> * for each ->resume method there should be a corresponding ->suspend method
>
> Moreover this whole wrapper driver seems strange, why not just add a proper
> runtime PM support to ahci_platform driver instead?
Hmm, even this shouldn't be needed as this wrapper driver doesn't have
->runtime_suspend and ->runtime resume methods.
What exactly is the purpose of the existence of this wrapper driver?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2013-09-25 12:50 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 13:05 [RFC PATCH 00/15] Add SATA support for TI OMAP5 and DRA7 SoCs Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` [RFC PATCH 01/15] phy: rename struct omap_control_usb to struct omap_control_phy Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
[not found] ` <1379595943-14622-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-09-19 14:25 ` Daniel Mack
2013-09-19 14:25 ` Daniel Mack
2013-09-19 14:25 ` Daniel Mack
2013-09-19 13:05 ` [RFC PATCH 02/15] phy: omap-control: Update DT binding information Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` [RFC PATCH 03/15] ARM: dts: omap5: Add clocks to usb3_phy node Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` [RFC PATCH 05/15] phy: omap-pipe3: Add SATA DPLL support Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` [RFC PATCH 06/15] phy: omap-pipe3: update compatibility string and DT binding Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` [RFC PATCH 07/15] ARM: dts: omap5: Update usb3phy node Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
[not found] ` <1379595943-14622-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-09-19 13:05 ` [RFC PATCH 04/15] phy: omap-pipe3: use generic clock names Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
[not found] ` <1379595943-14622-9-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-09-22 16:58 ` Tejun Heo
2013-09-22 16:58 ` Tejun Heo
2013-09-22 16:58 ` Tejun Heo
2013-09-22 18:24 ` Sergei Shtylyov
2013-09-22 18:24 ` Sergei Shtylyov
2013-09-22 21:51 ` Tejun Heo
2013-09-22 21:51 ` Tejun Heo
2013-09-23 7:37 ` Roger Quadros
2013-09-23 7:37 ` Roger Quadros
2013-09-23 7:37 ` Roger Quadros
[not found] ` <523FEFC2.801-l0cyMroinI0@public.gmane.org>
2013-09-23 12:59 ` Sergei Shtylyov
2013-09-23 12:59 ` Sergei Shtylyov
2013-09-23 12:59 ` Sergei Shtylyov
2013-09-23 13:59 ` Roger Quadros
2013-09-23 13:59 ` Roger Quadros
2013-09-23 13:59 ` Roger Quadros
2014-02-07 10:33 ` Roger Quadros
2014-02-07 10:33 ` Roger Quadros
2014-02-07 10:33 ` Roger Quadros
2014-02-07 10:39 ` Arnd Bergmann
2014-02-07 10:39 ` Arnd Bergmann
2014-02-07 10:39 ` Arnd Bergmann
2014-02-07 10:44 ` Roger Quadros
2014-02-07 10:44 ` Roger Quadros
2014-02-07 10:44 ` Roger Quadros
[not found] ` <20130922215107.GD27616-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-09-23 12:53 ` Sergei Shtylyov
2013-09-23 12:53 ` Sergei Shtylyov
2013-09-23 12:53 ` Sergei Shtylyov
[not found] ` <524039E0.2060205-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-09-25 12:16 ` Bartlomiej Zolnierkiewicz
2013-09-25 12:16 ` Bartlomiej Zolnierkiewicz
2013-09-25 12:16 ` Bartlomiej Zolnierkiewicz
2013-09-22 18:22 ` Sergei Shtylyov
2013-09-22 18:22 ` Sergei Shtylyov
[not found] ` <523F3567.80303-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-09-22 21:48 ` Tejun Heo
2013-09-22 21:48 ` Tejun Heo
2013-09-22 21:48 ` Tejun Heo
2013-09-23 14:10 ` Sergei Shtylyov
2013-09-23 14:10 ` Sergei Shtylyov
2013-09-23 14:12 ` Tejun Heo
2013-09-23 14:12 ` Tejun Heo
2013-09-23 7:42 ` Roger Quadros
2013-09-23 7:42 ` Roger Quadros
2013-09-23 7:42 ` Roger Quadros
2013-09-19 13:05 ` [RFC PATCH 09/15] ata: ti_sata: Add Texas Instruments SATA Wrapper driver Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-19 13:05 ` Roger Quadros
2013-09-25 12:37 ` Bartlomiej Zolnierkiewicz
2013-09-25 12:37 ` Bartlomiej Zolnierkiewicz
2013-09-25 12:49 ` Bartlomiej Zolnierkiewicz [this message]
2013-09-25 12:49 ` Bartlomiej Zolnierkiewicz
2013-09-25 13:29 ` Roger Quadros
2013-09-25 13:29 ` Roger Quadros
2013-09-25 13:29 ` Roger Quadros
2013-09-19 13:22 ` [RFC PATCH 10/15] ARM: omap5: hwmod: Add ocp2scp3 and sata hwmods Roger Quadros
2013-09-19 13:22 ` Roger Quadros
2013-09-19 13:22 ` Roger Quadros
2013-09-19 13:23 ` [RFC PATCH 11/15] arm: omap5: hwmod: add missing ocp2scp hwmod data Roger Quadros
2013-09-19 13:23 ` Roger Quadros
2013-09-19 13:23 ` Roger Quadros
2013-09-19 13:23 ` [RFC PATCH 12/15] ARM: dts: omap5: add ocp2scp1 address resource Roger Quadros
2013-09-19 13:23 ` Roger Quadros
2013-09-19 13:23 ` Roger Quadros
[not found] ` <1379597019-15294-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-09-19 14:17 ` Sergei Shtylyov
2013-09-19 14:17 ` Sergei Shtylyov
2013-09-19 14:17 ` Sergei Shtylyov
[not found] ` <523B0782.7050501-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-09-20 9:22 ` Roger Quadros
2013-09-20 9:22 ` Roger Quadros
2013-09-20 9:22 ` Roger Quadros
2013-09-19 13:23 ` [RFC PATCH 13/15] arm: dts: omap5: add sata node Roger Quadros
2013-09-19 13:23 ` Roger Quadros
2013-09-19 13:23 ` Roger Quadros
2013-09-19 13:24 ` [RFC PATCH 14/15] ARM: DRA7: hwmod: Add ocp2scp3 and sata hwmods Roger Quadros
2013-09-19 13:24 ` Roger Quadros
2013-09-19 13:24 ` Roger Quadros
2013-09-19 13:24 ` [RFC PATCH 15/15] arm: dts: dra7: add sata node Roger Quadros
2013-09-19 13:24 ` Roger Quadros
2013-09-19 13:24 ` Roger Quadros
[not found] ` <1379597059-15405-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-09-19 14:11 ` Sergei Shtylyov
2013-09-19 14:11 ` Sergei Shtylyov
2013-09-19 14:11 ` Sergei Shtylyov
[not found] ` <523B05FD.7020200-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-09-20 10:19 ` Roger Quadros
2013-09-20 10:19 ` Roger Quadros
2013-09-20 10:19 ` Roger Quadros
2013-09-22 18:45 ` Sergei Shtylyov
2013-09-22 18:45 ` Sergei Shtylyov
2013-09-23 8:24 ` Roger Quadros
2013-09-23 8:24 ` Roger Quadros
2013-09-23 8:24 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3930265.gHe05HETI5@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tj@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.