From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bX6UH-00077F-O9
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:50:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bX6UE-0000a0-Ha
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:50:29 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:55135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bX6UE-0000Zq-8a
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:50:26 -0400
Date: Tue, 9 Aug 2016 08:50:25 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <393082343.564767.1470747025500.JavaMail.zimbra@redhat.com>
In-Reply-To: <877fbqglj6.fsf@dusky.pond.sub.org>
References: <20160808141439.16908-1-marcandre.lureau@redhat.com>
	<20160808141439.16908-13-marcandre.lureau@redhat.com>
	<877fbqglj6.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>

Hi

----- Original Message -----
> marcandre.lureau@redhat.com writes:
>=20
> > From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> >
> > Replace the old manual dispatch and validation code by the generic one
> > provided by qapi common code.
> >
> > Note that it is now possible to call the following commands that used t=
o
> > be disabled by compile-time conditionals:
> > - dump-skeys
> > - query-spice
> > - rtc-reset-reinjection
> > - query-gic-capabilities
> >
> > Their fallback functions return an appropriate "feature disabled" error=
.
> >
> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>=20
> Means query-qmp-schema no longer shows whether these commands are
> supported, doesn't it?
>=20
> Eric, could this create difficulties for libvirt or other introspection
> users?

Thinking a bit about this, I guess it would be fairly straightforward to ha=
ve a new key "c-conditional" : "#ifdef CONFIG_SPICE" that would prepend it =
in C generated files, with a corresponding "#endif". Would that be acceptab=
le?