From: Thomas Monjalon <thomas@monjalon.net>
To: Wisam Jaddo <wisamm@mellanox.com>
Cc: arybchenko@solarflare.com, jackmin@mellanox.com,
jerinjacobk@gmail.com, ajit.khaparde@broadcom.com, dev@dpdk.org,
orika@mellanox.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v7 0/5] Introduce flow perf application
Date: Mon, 29 Jun 2020 16:15:43 +0200 [thread overview]
Message-ID: <3932794.yixytucIVQ@thomas> (raw)
In-Reply-To: <20200604133502.28491-1-wisamm@mellanox.com>
04/06/2020 15:34, Wisam Jaddo:
> Add new application to test rte flow performance from:
> - Insertion rate.
> - Deletion rate.
> - Memory consumption.
> - PPS forward measurement.
>
> Unchanged comments:
> - Prevent actions such as Queue from adding twice:
> * Current design don't support add actions twice.
> * This is performace app that not should force coditions like PMD.
> * If app allows adding dup actions and user added Queue the PMD should
> report the error.
> * No memory leak found.
>
> ---
> v7:
> * Move add_items/add_actions in items/actions instead of flow.
> * Have array of structures with loops instead of branching.
> * Add limitation part in doc.
> * Align items/actions generator methods with same signature.
> * Convert item/action & attrs selector to be 64bit instead of 32bit.
More than 3 weeks passed since this v7.
It looks to be good enough to be merged,
and let this new application to be improved with more features.
I fixed few minor details in maintainers, doc, etc.
Applied, thanks
next prev parent reply other threads:[~2020-06-29 14:15 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 13:46 [dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app Wisam Jaddo
2020-03-20 6:49 ` Jerin Jacob
2020-03-20 11:51 ` Thomas Monjalon
2020-03-20 12:18 ` Jerin Jacob
2020-03-23 9:53 ` Wisam Monther
2020-03-23 11:15 ` Jerin Jacob
2020-03-23 11:41 ` Wisam Monther
2020-03-23 13:00 ` Thomas Monjalon
2020-03-23 13:09 ` Wisam Monther
2020-04-09 15:42 ` [dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton Wisam Jaddo
2020-04-09 15:42 ` [dpdk-dev] [PATCH 2/5] app/test-flow-perf: add insertion rate calculation Wisam Jaddo
2020-04-17 2:07 ` Xiaoyu Min
2020-04-28 8:25 ` Wisam Monther
2020-04-09 15:42 ` [dpdk-dev] [PATCH 3/5] app/test-flow-perf: add deletion " Wisam Jaddo
2020-04-17 2:07 ` Xiaoyu Min
2020-04-28 8:25 ` Wisam Monther
2020-04-09 15:42 ` [dpdk-dev] [PATCH 4/5] app/test-flow-perf: add memory dump to app Wisam Jaddo
2020-04-17 2:08 ` Xiaoyu Min
2020-04-28 8:25 ` Wisam Monther
2020-04-09 15:42 ` [dpdk-dev] [PATCH 5/5] app/test-flow-perf: add packet forwarding support Wisam Jaddo
2020-04-17 2:09 ` Xiaoyu Min
2020-04-28 8:26 ` Wisam Monther
2020-04-28 14:09 ` Or Gerlitz
2020-04-29 9:49 ` Wisam Monther
2020-04-16 15:12 ` [dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton Wisam Monther
2020-04-17 2:05 ` Xiaoyu Min
2020-04-28 8:22 ` Wisam Monther
2020-04-30 7:08 ` [dpdk-dev] [PATCH v2 0/5] *** Introduce flow perf application *** Wisam Jaddo
2020-04-30 7:08 ` [dpdk-dev] [PATCH v2 1/5] app/test-flow-perf: add flow performance skeleton Wisam Jaddo
2020-04-30 9:32 ` [dpdk-dev] [PATCH v3 0/5] *** Introduce flow perf application *** Wisam Jaddo
2020-04-30 9:32 ` [dpdk-dev] [PATCH v3 1/5] app/test-flow-perf: add flow performance skeleton Wisam Jaddo
2020-04-30 10:33 ` [dpdk-dev] [PATCH v4 0/5] Introduce flow perf application Wisam Jaddo
2020-04-30 10:33 ` [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton Wisam Jaddo
2020-04-30 11:59 ` Xiaoyu Min
2020-05-04 10:16 ` Andrew Rybchenko
2020-05-05 10:45 ` Wisam Monther
2020-05-05 11:05 ` Thomas Monjalon
2020-05-05 10:47 ` Wisam Monther
2020-05-06 2:49 ` Ajit Khaparde
2020-05-06 7:32 ` Wisam Monther
2020-05-06 8:48 ` Andrew Rybchenko
2020-05-06 8:51 ` Wisam Monther
2020-05-06 8:54 ` Andrew Rybchenko
2020-05-06 12:36 ` [dpdk-dev] [PATCH v5 0/5] Introduce flow perf application Wisam Jaddo
2020-05-06 12:36 ` [dpdk-dev] [PATCH v5 1/5] app/flow-perf: add flow performance skeleton Wisam Jaddo
2020-05-06 14:25 ` Andrew Rybchenko
2020-05-06 17:07 ` Wisam Monther
2020-05-06 17:15 ` Andrew Rybchenko
2020-05-11 11:08 ` [dpdk-dev] [PATCH v6 0/5] Introduce flow perf application Wisam Jaddo
2020-05-11 11:08 ` [dpdk-dev] [PATCH v6 1/5] app/flow-perf: add flow performance skeleton Wisam Jaddo
2020-06-04 13:34 ` [dpdk-dev] [PATCH v7 0/5] Introduce flow perf application Wisam Jaddo
2020-06-04 13:34 ` [dpdk-dev] [PATCH v7 1/5] app/flow-perf: add flow performance skeleton Wisam Jaddo
2020-06-04 13:34 ` [dpdk-dev] [PATCH v7 2/5] app/flow-perf: add insertion rate calculation Wisam Jaddo
2020-06-25 7:04 ` Wisam Monther
2020-06-04 13:35 ` [dpdk-dev] [PATCH v7 3/5] app/flow-perf: add deletion " Wisam Jaddo
2020-06-04 13:35 ` [dpdk-dev] [PATCH v7 4/5] app/flow-perf: add memory dump to app Wisam Jaddo
2020-06-04 13:35 ` [dpdk-dev] [PATCH v7 5/5] app/flow-perf: add packet forwarding support Wisam Jaddo
2020-06-29 14:15 ` Thomas Monjalon [this message]
2020-05-11 11:08 ` [dpdk-dev] [PATCH v6 2/5] app/flow-perf: add insertion rate calculation Wisam Jaddo
2020-05-11 11:08 ` [dpdk-dev] [PATCH v6 3/5] app/flow-perf: add deletion " Wisam Jaddo
2020-05-11 11:08 ` [dpdk-dev] [PATCH v6 4/5] app/flow-perf: add memory dump to app Wisam Jaddo
2020-05-11 11:08 ` [dpdk-dev] [PATCH v6 5/5] app/flow-perf: add packet forwarding support Wisam Jaddo
2020-05-11 11:09 ` [dpdk-dev] [PATCH v6 0/5] Introduce flow perf application Wisam Jaddo
2020-05-11 11:09 ` [dpdk-dev] [PATCH v6 1/5] app/flow-perf: add flow performance skeleton Wisam Jaddo
2020-05-11 12:04 ` Andrew Rybchenko
2020-05-11 11:09 ` [dpdk-dev] [PATCH v6 2/5] app/flow-perf: add insertion rate calculation Wisam Jaddo
2020-05-11 12:05 ` Andrew Rybchenko
2020-05-12 10:34 ` Wisam Monther
2020-05-12 11:07 ` Andrew Rybchenko
2020-06-02 12:43 ` Wisam Monther
2020-05-11 11:09 ` [dpdk-dev] [PATCH v6 3/5] app/flow-perf: add deletion " Wisam Jaddo
2020-05-11 11:09 ` [dpdk-dev] [PATCH v6 4/5] app/flow-perf: add memory dump to app Wisam Jaddo
2020-05-11 11:09 ` [dpdk-dev] [PATCH v6 5/5] app/flow-perf: add packet forwarding support Wisam Jaddo
2020-05-06 12:36 ` [dpdk-dev] [PATCH v5 2/5] app/flow-perf: add insertion rate calculation Wisam Jaddo
2020-05-06 15:23 ` Andrew Rybchenko
2020-05-07 12:38 ` Wisam Monther
2020-05-06 12:36 ` [dpdk-dev] [PATCH v5 3/5] app/flow-perf: add deletion " Wisam Jaddo
2020-05-06 12:36 ` [dpdk-dev] [PATCH v5 4/5] app/flow-perf: add memory dump to app Wisam Jaddo
2020-05-06 12:36 ` [dpdk-dev] [PATCH v5 5/5] app/flow-perf: add packet forwarding support Wisam Jaddo
2020-05-06 12:50 ` [dpdk-dev] [PATCH v5 0/5] Introduce flow perf application Thomas Monjalon
2020-04-30 10:33 ` [dpdk-dev] [PATCH v4 2/5] app/test-flow-perf: add insertion rate calculation Wisam Jaddo
2020-04-30 12:00 ` Xiaoyu Min
2020-05-04 12:01 ` Andrew Rybchenko
2020-05-06 4:00 ` Ajit Khaparde
2020-05-06 12:33 ` Wisam Monther
2020-04-30 10:33 ` [dpdk-dev] [PATCH v4 3/5] app/test-flow-perf: add deletion " Wisam Jaddo
2020-04-30 12:02 ` Xiaoyu Min
2020-04-30 10:33 ` [dpdk-dev] [PATCH v4 4/5] app/test-flow-perf: add memory dump to app Wisam Jaddo
2020-04-30 12:03 ` Xiaoyu Min
2020-05-06 4:10 ` Ajit Khaparde
2020-04-30 10:33 ` [dpdk-dev] [PATCH v4 5/5] app/test-flow-perf: add packet forwarding support Wisam Jaddo
2020-04-30 12:05 ` Xiaoyu Min
2020-05-04 7:12 ` [dpdk-dev] [PATCH v4 0/5] Introduce flow perf application Thomas Monjalon
2020-04-30 9:32 ` [dpdk-dev] [PATCH v3 2/5] app/test-flow-perf: add insertion rate calculation Wisam Jaddo
2020-04-30 9:32 ` [dpdk-dev] [PATCH v3 3/5] app/test-flow-perf: add deletion " Wisam Jaddo
2020-04-30 9:32 ` [dpdk-dev] [PATCH v3 4/5] app/test-flow-perf: add memory dump to app Wisam Jaddo
2020-04-30 9:32 ` [dpdk-dev] [PATCH v3 5/5] app/test-flow-perf: add packet forwarding support Wisam Jaddo
2020-04-30 7:08 ` [dpdk-dev] [PATCH v2 2/5] app/test-flow-perf: add insertion rate calculation Wisam Jaddo
2020-04-30 7:08 ` [dpdk-dev] [PATCH v2 3/5] app/test-flow-perf: add deletion " Wisam Jaddo
2020-04-30 7:08 ` [dpdk-dev] [PATCH v2 4/5] app/test-flow-perf: add memory dump to app Wisam Jaddo
2020-04-30 7:08 ` [dpdk-dev] [PATCH v2 5/5] app/test-flow-perf: add packet forwarding support Wisam Jaddo
2020-05-06 3:00 ` [dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3932794.yixytucIVQ@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jackmin@mellanox.com \
--cc=jerinjacobk@gmail.com \
--cc=orika@mellanox.com \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.