From: "Colin King (gmail)" <colin.i.king@googlemail.com>
To: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
Colin Ian King <colin.i.king@googlemail.com>,
"Coelho, Luciano" <luciano.coelho@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and error message
Date: Mon, 29 Nov 2021 12:45:55 +0000 [thread overview]
Message-ID: <39358e61-c2fb-356a-2ddd-4e87232bfe57@gmail.com> (raw)
In-Reply-To: <SA1PR11MB58258E8E9DA01215009B2273F2669@SA1PR11MB5825.namprd11.prod.outlook.com>
On 29/11/2021 12:34, Grumbach, Emmanuel wrote:
> Hi Colin,
>
>> Subject: [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and
>> error message
>>
>> There is a spelling mistake in a dev_err message and also in a devfs
>> filename. Fix these.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>> drivers/net/wireless/intel/iwlwifi/mei/main.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> b/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> index 112cc362e8e7..ed208f273289 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> @@ -209,7 +209,7 @@ static void iwl_mei_free_shared_mem(struct
>> mei_cl_device *cldev)
>> struct iwl_mei *mei = mei_cldev_get_drvdata(cldev);
>>
>> if (mei_cldev_dma_unmap(cldev))
>> - dev_err(&cldev->dev, "Coudln't unmap the shared mem
>> properly\n");
>> + dev_err(&cldev->dev, "Couldn't unmap the shared mem
>> properly\n");
>> memset(&mei->shared_mem, 0, sizeof(mei->shared_mem));
>> }
>
> I fixed this one already in a separate patch that hasn't been applied yet.
>
>>
>> @@ -1754,7 +1754,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei
>> *mei)
>> mei->dbgfs_dir, &iwl_mei_status);
>> debugfs_create_file("send_start_message", S_IWUSR, mei-
>>> dbgfs_dir,
>> mei, &iwl_mei_dbgfs_send_start_message_ops);
>> - debugfs_create_file("req_ownserhip", S_IWUSR, mei->dbgfs_dir,
>> + debugfs_create_file("req_ownership", S_IWUSR, mei->dbgfs_dir,
>> mei, &iwl_mei_dbgfs_req_ownership_ops);
>> }
>>
>> --
>
> I hadn't stop this one.
I'll send a V2 with the debugfs fix
>
>> 2.33.1
>
prev parent reply other threads:[~2021-11-29 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 12:25 [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and error message Colin Ian King
2021-11-29 12:34 ` Grumbach, Emmanuel
2021-11-29 12:45 ` Colin King (gmail) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39358e61-c2fb-356a-2ddd-4e87232bfe57@gmail.com \
--to=colin.i.king@googlemail.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.