From: Paolo Bonzini <pbonzini@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Xishi Qiu <qiuxishi@huawei.com>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
the arch/x86 maintainers <x86@kernel.org>,
wanpeng li <wanpeng.li@hotmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
hidehiro kawai ez <hidehiro.kawai.ez@hitachi.com>,
LKML <linux-kernel@vger.kernel.org>,
Fengtiantian <fengtiantian@huawei.com>,
Xiexiuqi <xiexiuqi@huawei.com>
Subject: Re: [PATCH V4] x86: call smp vmxoff in smp stop
Date: Wed, 19 Apr 2017 04:22:01 -0400 (EDT) [thread overview]
Message-ID: <393949858.14449581.1492590121377.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170419080254.c3j5lwztad2fswwr@gmail.com>
> > On 18/01/2017 12:32, Xishi Qiu wrote:
> > > From: Tiantian Feng <fengtiantian@huawei.com>
> > >
> > > We need to disable VMX on all CPUs before stop cpu when OS panic,
> > > otherwisewe risk hanging up the machine, because the CPU ignore INIT
> > > signals when VMX is enabled. In kernel mainline this issue existence.
>
> Yes, but the changelog is atrcious:
>
> - title should describe the purpose, not the implementation
>
> - CPU is spelled 'CPU' once, then 'cpu' _in the same sentence_!
>
> - typos
>
> - spelling
>
> - the last sentence doesn't even parse ...
>
> Still it's already at V4 and comes with two signoffs and what amounts to a
> maintainer Ack??
Well, the v2-v4 were really just about getting the signoffs right. At some
point you just get desensitized about the changelog. :(
I'll post v5 with a rewritten commit message.
Paolo
next prev parent reply other threads:[~2017-04-19 8:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 10:11 [RFC PATCH] x86: call smp vmxoff in smp stop Xishi Qiu
2017-01-05 1:45 ` [RFC PATCH V2] " Xishi Qiu
2017-01-12 13:55 ` Paolo Bonzini
2017-01-14 1:42 ` [PATCH V3] " Xishi Qiu
2017-01-17 15:18 ` Paolo Bonzini
2017-01-18 2:19 ` Xishi Qiu
2017-01-18 9:30 ` Paolo Bonzini
2017-01-18 11:32 ` [PATCH V4] " Xishi Qiu
2017-04-18 13:34 ` Paolo Bonzini
2017-04-19 8:02 ` Ingo Molnar
2017-04-19 8:22 ` Paolo Bonzini [this message]
2017-04-19 9:50 ` Ingo Molnar
2017-01-14 1:36 ` [PATCH] " Xishi Qiu
2017-01-14 1:41 ` Xishi Qiu
2017-01-15 0:45 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=393949858.14449581.1492590121377.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fengtiantian@huawei.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
--cc=x86@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.