From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933533AbdDSIWF (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Apr 2017 04:22:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55186 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1760830AbdDSIWC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Apr 2017 04:22:02 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D071A31F405
Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D071A31F405
Date: Wed, 19 Apr 2017 04:22:01 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Xishi Qiu <qiuxishi@huawei.com>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        the arch/x86 maintainers <x86@kernel.org>,
        wanpeng li <wanpeng.li@hotmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        hidehiro kawai ez <hidehiro.kawai.ez@hitachi.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Fengtiantian <fengtiantian@huawei.com>, Xiexiuqi <xiexiuqi@huawei.com>
Message-ID: <393949858.14449581.1492590121377.JavaMail.zimbra@redhat.com>
In-Reply-To: <20170419080254.c3j5lwztad2fswwr@gmail.com>
References: <586CCA5A.8050607@huawei.com> <586DA529.1040803@huawei.com> <58798201.2@huawei.com> <587F523B.80301@huawei.com> <3d5bf4c2-7415-a976-62fb-ba653f92eada@redhat.com> <20170419080254.c3j5lwztad2fswwr@gmail.com>
Subject: Re: [PATCH V4] x86: call smp vmxoff in smp stop
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.4.164.1, 10.4.195.1]
Thread-Topic: x86: call smp vmxoff in smp stop
Thread-Index: UGHT06RuI908U3VtPEYFj/jGUoGl5Q==
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 19 Apr 2017 08:22:02 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > On 18/01/2017 12:32, Xishi Qiu wrote:
> > > From: Tiantian Feng <fengtiantian@huawei.com>
> > > 
> > > We need to disable VMX on all CPUs before stop cpu when OS panic,
> > > otherwisewe risk hanging up the machine, because the CPU ignore INIT
> > > signals when VMX is enabled. In kernel mainline this issue existence.
> 
> Yes, but the changelog is atrcious:
> 
>  - title should describe the purpose, not the implementation
> 
>  - CPU is spelled 'CPU' once, then 'cpu' _in the same sentence_!
> 
>  - typos
> 
>  - spelling
> 
>  - the last sentence doesn't even parse ...
> 
> Still it's already at V4 and comes with two signoffs and what amounts to a
> maintainer Ack??

Well, the v2-v4 were really just about getting the signoffs right.  At some
point you just get desensitized about the changelog. :(

I'll post v5 with a rewritten commit message.

Paolo