From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Pedro Aguilar <paguilar@paguilar.org>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/1] package/guile: Guile 3.0.7 requires libiconv.
Date: Sun, 6 Feb 2022 09:54:44 +0100 [thread overview]
Message-ID: <3942047e-e69e-d079-3ca5-55409fdda839@benettiengineering.com> (raw)
In-Reply-To: <20220206084334.1900252-1-paguilar@paguilar.org>
Too fast...
On 06/02/22 09:43, Pedro Aguilar wrote:
> This fixes the error reported in the daily results.
>
> Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
> ---
> package/guile/Config.in | 1 +
> package/guile/guile.mk | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/guile/Config.in b/package/guile/Config.in
> index b1182a4cee..2367a3ed3d 100644
> --- a/package/guile/Config.in
> +++ b/package/guile/Config.in
> @@ -9,6 +9,7 @@ config BR2_PACKAGE_GUILE
> select BR2_PACKAGE_LIBFFI
> select BR2_PACKAGE_GMP
> select BR2_PACKAGE_BDWGC
> + select BR2_PACKAGE_LIBICONV
> help
> Guile is an interpreter and compiler for the Scheme
> programming language, a clean and elegant dialect of Lisp.
> diff --git a/package/guile/guile.mk b/package/guile/guile.mk
> index 0f245fca76..0f26443023 100644
> --- a/package/guile/guile.mk
> +++ b/package/guile/guile.mk
> @@ -15,7 +15,7 @@ GUILE_LICENSE = LGPL-3.0+
> GUILE_LICENSE_FILES = LICENSE COPYING COPYING.LESSER
> GUILE_CPE_ID_VENDOR = gnu
>
> -GUILE_DEPENDENCIES = host-guile libunistring libffi gmp bdwgc host-pkgconf
> +GUILE_DEPENDENCIES = host-guile libunistring libffi gmp bdwgc host-pkgconf libiconv
Here ^^^ please keep alphabetical order, so libiconv goes before
libunistring and doing so can you please move host-pkgconf after host-guile?
Thank you!
--
Giulio Benetti
Benetti Engineering sas
> HOST_GUILE_DEPENDENCIES = host-libunistring host-libffi host-gmp host-bdwgc host-flex host-pkgconf host-gettext
>
> # The HAVE_GC* CFLAGS specify that we will use internal callbacks
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-06 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 8:43 [Buildroot] [PATCH v1 1/1] package/guile: Guile 3.0.7 requires libiconv Pedro Aguilar
2022-02-06 8:48 ` Giulio Benetti
2022-02-06 8:54 ` Giulio Benetti [this message]
2022-02-06 9:30 ` Thomas Petazzoni via buildroot
2022-02-08 9:19 ` Pedro Aguilar
2022-02-08 11:47 ` Giulio Benetti
2022-02-08 12:02 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3942047e-e69e-d079-3ca5-55409fdda839@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=buildroot@buildroot.org \
--cc=paguilar@paguilar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.