All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Haiyue" <haiyue.wang@linux.intel.com>
To: minyard@acm.org, arnd@arndb.de, gregkh@linuxfoundation.org,
	openipmi-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Cc: luis.a.silva@dell.com, avi.fishman@nuvoton.com, openbmc@lists.ozlabs.org
Subject: Re: [PATCH ] ipmi: kcs_bmc: fix IRQ exception if the channel is not open
Date: Sat, 23 Jun 2018 01:43:16 +0800	[thread overview]
Message-ID: <3950b9ff-79d6-b0f8-91fb-1a13b34c24d2@linux.intel.com> (raw)
In-Reply-To: <980bbe06-afa6-67b0-a3d3-c5fd921dcfbd@linux.intel.com>



On 2018-06-23 01:23, Wang, Haiyue wrote:
>> Maybe it's best to have the interrupt disabled unless the device is 
>> open.
>> You have to handle the interrupt disable race on a close, but with the
>> sync functions that shouldn't be too hard.
>>
> In fact, in BMC chip design, the LPC controller has many devices, such as
> Port 80 snoop, BT, KCS etc, they shares the same interrupt. :) 
BTW, for AST2500, if the BMC and PCH run under eSPI (like LPC) mode, and 
if we
disable the KCS devices, then reboot the BMC, it will cause the system 
hang, and
the KCS channel can't be used anymore. So we need always enable these 
used KCS
devices (keep the KCS enable register setting) for working well under 
eSPI mode.

      reply	other threads:[~2018-06-22 17:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22  2:56 [PATCH ] ipmi: kcs_bmc: fix IRQ exception if the channel is not open Haiyue Wang
2018-06-22 12:43 ` Corey Minyard
2018-06-22 17:23   ` Wang, Haiyue
2018-06-22 17:43     ` Wang, Haiyue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3950b9ff-79d6-b0f8-91fb-1a13b34c24d2@linux.intel.com \
    --to=haiyue.wang@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=avi.fishman@nuvoton.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis.a.silva@dell.com \
    --cc=minyard@acm.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.