All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Jiri Slaby <jslaby@suse.cz>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Sergei Zviagintsev <sergei@s15v.net>,
	Peter Hurley <peter@hurleysoftware.com>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Sebastian Reichel <sre@kernel.org>, NeilBrown <neil@brown.name>,
	Grant Likely <grant.likely@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org, Marek Belisko <marek@goldelico.com>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver
Date: Fri, 16 Oct 2015 21:06:14 +0200	[thread overview]
Message-ID: <3951119.loGSTxYIZb@wuerfel> (raw)
In-Reply-To: <c53ab7a3ca68f8b9f802c1ea799d72e1cb04a1eb.1445018913.git.hns@goldelico.com>

On Friday 16 October 2015 20:08:35 H. Nikolaus Schaller wrote:
> +
> +static int w2sg_data_probe(struct platform_device *pdev)
> +{
> +       struct w2sg_pdata *pdata = dev_get_platdata(&pdev->dev);
> +       struct w2sg_data *data;
> +       struct rfkill *rf_kill;
> +       int err;
> +
> +       pr_debug("%s()\n", __func__);
> +
> +       if (pdev->dev.of_node) {
> +               struct device *dev = &pdev->dev;
> +               enum of_gpio_flags flags;
> +
> +               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> +               if (!pdata)
> 

Why is this a platform_device and not a serio_device?

	Arnd

  parent reply	other threads:[~2015-10-16 19:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 18:08 [PATCH v3 0/3] UART slave device support (goldelico version) H. Nikolaus Schaller
2015-10-16 18:08 ` [PATCH v3 1/3] tty: serial core: provide a method to search uart by phandle H. Nikolaus Schaller
2015-10-16 18:39   ` Mark Rutland
2015-10-16 19:24     ` H. Nikolaus Schaller
2015-10-16 18:47   ` kbuild test robot
2015-10-16 18:47     ` kbuild test robot
     [not found]   ` <c46694357c903d8791f07e2ec287c684832056a5.1445018913.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-10-16 19:05     ` Arnd Bergmann
2015-10-16 19:05       ` Arnd Bergmann
2015-10-16 19:29   ` kbuild test robot
2015-10-16 19:29     ` kbuild test robot
2015-10-16 18:08 ` [PATCH v3 2/3] tty: serial_core: add hooks for uart slave drivers H. Nikolaus Schaller
2015-10-16 18:08 ` [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver H. Nikolaus Schaller
     [not found]   ` <c53ab7a3ca68f8b9f802c1ea799d72e1cb04a1eb.1445018913.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-10-16 18:15     ` H. Nikolaus Schaller
2015-10-16 18:15       ` H. Nikolaus Schaller
2015-10-16 19:06   ` Arnd Bergmann [this message]
2015-10-16 19:27     ` H. Nikolaus Schaller
2015-10-16 19:38       ` Arnd Bergmann
2015-10-16 20:07         ` H. Nikolaus Schaller
2015-10-16 23:45   ` kbuild test robot
2015-10-16 23:45     ` kbuild test robot
2015-10-16 19:11 ` [PATCH v3 0/3] UART slave device support (goldelico version) H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3951119.loGSTxYIZb@wuerfel \
    --to=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=grant.likely@linaro.org \
    --cc=hns@goldelico.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jslaby@suse.cz \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marek@goldelico.com \
    --cc=mark.rutland@arm.com \
    --cc=neil@brown.name \
    --cc=pawel.moll@arm.com \
    --cc=peter@hurleysoftware.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei@s15v.net \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.