From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTCFC-0001QL-QF for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:38:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTCF8-0007dA-Nx for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:38:30 -0500 Received: from nm20.bullet.mail.sg3.yahoo.com ([106.10.148.71]:48935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTCF7-0007bM-Sv for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:38:26 -0500 Date: Tue, 9 Feb 2016 17:38:08 +0000 (UTC) From: P J P Message-ID: <395629496.1184913.1455039488057.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: <56B8C819.2090806@redhat.com> References: <56B8C819.2090806@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] ahci: unmap fixes Reply-To: P J P List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , "qemu-block@nongnu.org" Cc: "peter.maydell@linaro.org" , "pbonzini@redhat.com" , "qemu-devel@nongnu.org" , "zuozhi.fzz@alibaba-inc.com" > On Monday, 8 February 2016 10:23 PM, John Snow wrote: >> PJP, ping? Look good? Oops, sorry! > On 01/29/2016 04:41 PM, John Snow wrote: >> As reported by Zuozhi fzz , there's a problem >> you can expose in AHCI by rewriting the command list buffer and/or FIS >> receive buffer addresses, then re-starting the AHCI device before bringing >> it to a stop. Depending on the success of the remap operations, you may >> be able to transition the device to a state where it thinks it is >> "running" but no longer has a guest memory mapping. >> >> When you try to transition it to the stopped state, QEMU crashes. >> >> Tighten up the start/stop conditions, and pepper in a paranoia check inside >> of the unmap function. >> >> John Snow (4): >> ahci: Do not unmap NULL addresses >> ahci: handle LIST_ON and FIS_ON in map helpers >> ahci: explicitly reject bad engine states on post_load >> ahci: prohibit "restarting" the FIS or CLB engines Yes, they look good. Thank you. --- -P J P http://feedmug.com