From: Thomas Monjalon <thomas@monjalon.net>
To: Weiguo Li <liwg06@foxmail.com>
Cc: cristian.dumitrescu@intel.com, dev@dpdk.org,
jasvinder.singh@intel.com,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5] sched: remove useless malloc in pie data init
Date: Mon, 07 Mar 2022 19:35:07 +0100 [thread overview]
Message-ID: <39592950.J2Yia2DhmK@thomas> (raw)
In-Reply-To: <tencent_400C07CFD7297584B78EF737D60880484406@qq.com>
01/03/2022 21:32, Weiguo Li:
> 'rte_pie_rt_data_init(NULL)' is not expected, and it's ought to
> fail when this happen. The malloc inside the function didn't work.
> So remove the malloc otherwise will lead to a memory leak.
>
> Fixes: 44c730b0e37971 ("sched: add PIE based congestion management")
>
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v5:
> * fix compile error
> v4:
> * replace all assignments to zero by a memset.
> v3:
> * fix typo
> v2:
> * revise according to Stephen's suggestion.
Applied, thanks.
prev parent reply other threads:[~2022-03-07 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 14:55 [PATCH] sched: add parentheses to if clause Weiguo Li
2022-02-26 17:31 ` Stephen Hemminger
2022-02-27 5:23 ` Weiguo Li
2022-02-27 5:25 ` [PATCH v2] sched: remove useless malloc in pie data init Weiguo Li
2022-03-01 6:07 ` [PATCH v3] " Weiguo Li
2022-03-01 17:08 ` Stephen Hemminger
2022-03-01 18:00 ` Dumitrescu, Cristian
2022-03-01 18:58 ` [PATCH v4] " Weiguo Li
2022-03-01 20:32 ` [PATCH v5] " Weiguo Li
2022-03-07 18:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39592950.J2Yia2DhmK@thomas \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=liwg06@foxmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.