From: Tomasz Figa <tomasz.figa@gmail.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
kgene.kim@samsung.com, grant.likely@secretlab.ca,
dianders@chromium.org, jg1.han@samsung.com
Subject: Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos
Date: Wed, 16 Jan 2013 08:49:23 +0100 [thread overview]
Message-ID: <3963234.Gb249i4a6U@flatron> (raw)
In-Reply-To: <1358257112-19595-4-git-send-email-gautam.vivek@samsung.com>
Hi Vivek,
Don't you need also some clkdev lookup entry to make the clock available
in the driver?
Best regards,
Tomasz
On Tuesday 15 of January 2013 19:08:31 Vivek Gautam wrote:
> Adding necessary device clock to exynos5 needed for
> the DWC3 controller.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++
> 1 files changed, 24 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/clock-exynos5.c
> b/arch/arm/mach-exynos/clock-exynos5.c index 0208c3a..13af020 100644
> --- a/arch/arm/mach-exynos/clock-exynos5.c
> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> @@ -757,6 +757,11 @@ static struct clk exynos5_init_clocks_off[] = {
> .enable = exynos5_clk_ip_fsys_ctrl ,
> .ctrlbit = (1 << 18),
> }, {
> + .name = "usbdrd30",
> + .parent = &exynos5_clk_aclk_200.clk,
> + .enable = exynos5_clk_ip_fsys_ctrl,
> + .ctrlbit = (1 << 19),
> + }, {
> .name = "usbotg",
> .enable = exynos5_clk_ip_fsys_ctrl,
> .ctrlbit = (1 << 7),
> @@ -1035,6 +1040,16 @@ static struct clksrc_sources exynos5_clkset_group
> = { .nr_sources = ARRAY_SIZE(exynos5_clkset_group_list),
> };
>
> +struct clk *exynos5_clkset_usbdrd30_list[] = {
> + [0] = &exynos5_clk_mout_mpll.clk,
> + [1] = &exynos5_clk_mout_cpll.clk,
> +};
> +
> +struct clksrc_sources exynos5_clkset_usbdrd30 = {
> + .sources = exynos5_clkset_usbdrd30_list,
> + .nr_sources = ARRAY_SIZE(exynos5_clkset_usbdrd30_list),
> +};
> +
> /* Possible clock sources for aclk_266_gscl_sub Mux */
> static struct clk *clk_src_gscl_266_list[] = {
> [0] = &clk_ext_xtal_mux,
> @@ -1329,6 +1344,15 @@ static struct clksrc_clk exynos5_clksrcs[] = {
> .parent = &exynos5_clk_mout_cpll.clk,
> },
> .reg_div = { .reg = EXYNOS5_CLKDIV_GEN, .shift = 4, .size = 3
},
> + }, {
> + .clk = {
> + .name = "sclk_usbdrd30",
> + .enable = exynos5_clksrc_mask_fsys_ctrl,
> + .ctrlbit = (1 << 28),
> + },
> + .sources = &exynos5_clkset_usbdrd30,
> + .reg_src = { .reg = EXYNOS5_CLKSRC_FSYS, .shift = 28, .size =
1 },
> + .reg_div = { .reg = EXYNOS5_CLKDIV_FSYS0, .shift = 24, .size =
4 },
> },
> };
next prev parent reply other threads:[~2013-01-16 7:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 13:38 [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 Vivek Gautam
2013-01-15 13:38 ` [PATCH v4 1/4] ARM: Exynos5250: Enabling ehci-s5p driver Vivek Gautam
2013-01-16 5:21 ` Vivek Gautam
2013-01-16 5:45 ` [PATCH v5 " Vivek Gautam
2013-01-16 7:51 ` Tomasz Figa
2013-02-08 22:35 ` Kukjin Kim
2013-02-15 5:09 ` Vivek Gautam
2013-01-15 13:38 ` [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver Vivek Gautam
2013-01-16 7:44 ` Tomasz Figa
2013-01-16 15:09 ` Vivek Gautam
2013-01-31 22:26 ` Kukjin Kim
2013-01-31 22:26 ` Kukjin Kim
2013-02-04 11:15 ` Vivek Gautam
2013-02-04 11:15 ` Vivek Gautam
[not found] ` <1358257112-19595-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-01-15 13:38 ` [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos Vivek Gautam
2013-01-15 13:38 ` Vivek Gautam
2013-01-16 7:49 ` Tomasz Figa [this message]
2013-01-16 15:05 ` Vivek Gautam
[not found] ` <CAFp+6iHd66_dvj_M5zOpJZ7sEy-pYa-CdWKUZBYc3Dfn3JHtfg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-23 13:15 ` Vivek Gautam
2013-01-23 13:15 ` Vivek Gautam
2013-01-30 6:54 ` Kukjin Kim
2013-01-29 7:07 ` Vivek Gautam
2013-01-15 13:38 ` [PATCH v4 4/4] ARM: Exynos5250: Enabling dwc3-exynos driver Vivek Gautam
2013-01-15 13:38 ` Vivek Gautam
2013-01-16 7:51 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3963234.Gb249i4a6U@flatron \
--to=tomasz.figa@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=gautam.vivek@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.