All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Scott <nscott@aconex.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: simplify and unify source package generation
Date: Mon, 26 Oct 2009 09:36:45 +1100 (EST)	[thread overview]
Message-ID: <396549975.11101256510205184.JavaMail.root@mail-au.aconex.com> (raw)
In-Reply-To: <20091025074715.GC9482@infradead.org>


----- "Christoph Hellwig" <hch@infradead.org> wrote:

> On Tue, Oct 13, 2009 at 10:49:51AM +1100, Nathan Scott wrote:
> > >From looking through the patch it seems OK to me.  I haven't had a
> chance
> > to test it out yet, though - but from just eyeballing it, and if
> noone
> > pipes up complaining about the auto-rpm-build removal (I don't
> expect
> > they will, at this stage of xfsprogs life) it all looks good and
> correct.
> 
> Thanks.  Does this count as a reviewed-by?

Yep, sorry - Reviewed-by: Nathan Scott <nathans@debian.org>

> Btw, one other thing I'm pondering is removing the automatic call to
> ./configure from make if it's not configured yet.  It causes lots of 
> pain for the toplevel makefile and the makefile snipplets in
> include/.
> We'd have to replace the .deb building makefile snipplet with a
> build-debs.sh shell script, but that might be cleaner anyway.

Its not so bad IMO & we seem to be getting into the realm of gratuitous
change, but - *shrug* - doesn't make much difference I guess, I'm sure
people will figure it out pretty quickly.

cheers.

-- 
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-10-25 22:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11  2:45 [PATCH] xfsprogs: simplify and unify source package generation Christoph Hellwig
2009-10-12 23:49 ` Nathan Scott
2009-10-13  0:29   ` Eric Sandeen
2009-10-25  7:47   ` Christoph Hellwig
2009-10-25 22:36     ` Nathan Scott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=396549975.11101256510205184.JavaMail.root@mail-au.aconex.com \
    --to=nscott@aconex.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.