From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DF3C433DB for ; Wed, 3 Feb 2021 11:22:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A23C64F67 for ; Wed, 3 Feb 2021 11:22:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A23C64F67 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XlsXpyxjqMeN/flTTHiJZBlZw2xDWxcwUNRBaAbkBoI=; b=LylpZIQuKMaIep1JDwCPCvbeV P44oFrUDQJ1I+O3tv+uiUWqiN9WlYq5LQ9pDhGierYtxbOIhp9lJ0fHIJNlroQv6EcYokeSzM3mAX 6cg8bmjLw/bcXKkFGJdzuvc9eQCU0De6Jm+yP93jI7cJtYMeJdla89yRA8hk+w1RitknYuhqJNfkI mZWxEirDSaXzjOR1pibj9Z5Am6m/EN5Yq+LXJ05HIZHpP6fBfSlCQFtYbrCWftFFi80e9xJiyHICc pMHAoYi7lVv6fzyv4AiKdrXCyvLh4YtifvDTMXxUYp9catlZvfbF5uIDuKdtkMpnN0KTf8PWZ5ir7 djcSAjNeA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7GFJ-0001Wr-0q; Wed, 03 Feb 2021 11:22:53 +0000 Received: from smtp-fw-9103.amazon.com ([207.171.188.200]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7GFF-0001WC-TS for linux-nvme@lists.infradead.org; Wed, 03 Feb 2021 11:22:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1612351369; x=1643887369; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=18cLPBSgASmoHqw1uCd93wj7L5Z/l3QTe+arYV9VCPw=; b=ngknBz5YG9tnMhU43qlGg9Vsltl7/VxjBpFvcrtMKY7shQSVz9yX7jaL Tlsrc+JlTaHhTlgPm3Fwtu/fhInQMDXQtqyYM2aqG+awpWOT/7wPnsItR YeYrcnTJ3CX68YdKZyXXQbRR4+Fd1Da1teWIMD684wpvotulM6OSk7gI9 E=; X-IronPort-AV: E=Sophos;i="5.79,398,1602547200"; d="scan'208";a="915302612" Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-119b4f96.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9103.sea19.amazon.com with ESMTP; 03 Feb 2021 11:22:36 +0000 Received: from EX13MTAUEE002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-119b4f96.us-west-2.amazon.com (Postfix) with ESMTPS id CDCC91AADE7; Wed, 3 Feb 2021 11:22:35 +0000 (UTC) Received: from EX13D08UEE001.ant.amazon.com (10.43.62.126) by EX13MTAUEE002.ant.amazon.com (10.43.62.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Feb 2021 11:22:35 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D08UEE001.ant.amazon.com (10.43.62.126) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Feb 2021 11:22:35 +0000 Received: from u2196cf9297dc59.ant.amazon.com (10.1.212.5) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 3 Feb 2021 11:22:33 +0000 To: Christoph Hellwig References: <20210203094338.19473-1-sironi@amazon.de> <20210203095148.GA8897@lst.de> <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> <20210203111548.GA11075@lst.de> From: Filippo Sironi Message-ID: <396b45d5-3dd5-8159-34c2-5668510d1d68@amazon.de> Date: Wed, 3 Feb 2021 12:22:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210203111548.GA11075@lst.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_062250_084170_3C317C75 X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, serebrin@amazon.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org, dwmw@amazon.co.uk Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2/3/21 12:15 PM, Christoph Hellwig wrote: > > On Wed, Feb 03, 2021 at 12:12:31PM +0100, Filippo Sironi wrote: >> I don't disagree on the first part of your sentence, this is a big >> oversight. > > But it is not what your commit log suggests. I can definitely rephrase the commit. >> On the other hand, those controllers are out there and are in use by a lot >> of customers. We can keep relying on luck, hoping that customers don't run >> into troubles or we can merge a few lines of code :) > > Your patch does not just quirk a few controllers out there, but all > current and future controllers with an Amazon vendor ID. We could > probably talk about quirking an existing vendor ID or two as long as > this doesn't happen for future hardware. I know that the hardware team is working on this but I don't know the timelines and there are a few upcoming controllers - of which I don't know the device ids yet - that have the same issue. To avoid issues, it is easier to apply the quirk to all Amazon NVMe controllers for now till the new lines of controllers with the fix comes out. At that point, we'll be able to restrict the application to the known bad controllers. Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1EAEC43217 for ; Wed, 3 Feb 2021 11:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 714C264DE8 for ; Wed, 3 Feb 2021 11:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234092AbhBCLXx (ORCPT ); Wed, 3 Feb 2021 06:23:53 -0500 Received: from smtp-fw-9103.amazon.com ([207.171.188.200]:40712 "EHLO smtp-fw-9103.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234218AbhBCLXZ (ORCPT ); Wed, 3 Feb 2021 06:23:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1612351404; x=1643887404; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=18cLPBSgASmoHqw1uCd93wj7L5Z/l3QTe+arYV9VCPw=; b=e6IwtyXC6AI3Uy9uIlEI8VIKI9ONgk56ua/9AIXy+2RaASWimUDBXSHW u44vYD6l2jjap3BXEbSG2+wdEAUN2UDfX9aYs2NuvTF0MzXMSWq3XlXEh u7WEOrqwUB1Ur9MZ46gUGyVnqDLa8qxZM2AoDEDx6z0YOjT+RN5ASZRco w=; X-IronPort-AV: E=Sophos;i="5.79,398,1602547200"; d="scan'208";a="915302612" Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-119b4f96.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9103.sea19.amazon.com with ESMTP; 03 Feb 2021 11:22:36 +0000 Received: from EX13MTAUEE002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-119b4f96.us-west-2.amazon.com (Postfix) with ESMTPS id CDCC91AADE7; Wed, 3 Feb 2021 11:22:35 +0000 (UTC) Received: from EX13D08UEE001.ant.amazon.com (10.43.62.126) by EX13MTAUEE002.ant.amazon.com (10.43.62.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Feb 2021 11:22:35 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D08UEE001.ant.amazon.com (10.43.62.126) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Feb 2021 11:22:35 +0000 Received: from u2196cf9297dc59.ant.amazon.com (10.1.212.5) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 3 Feb 2021 11:22:33 +0000 To: Christoph Hellwig CC: , , , , , , References: <20210203094338.19473-1-sironi@amazon.de> <20210203095148.GA8897@lst.de> <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> <20210203111548.GA11075@lst.de> From: Filippo Sironi Message-ID: <396b45d5-3dd5-8159-34c2-5668510d1d68@amazon.de> Date: Wed, 3 Feb 2021 12:22:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210203111548.GA11075@lst.de> Content-Language: en-US Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ck9uIDIvMy8yMSAxMjoxNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gCj4gT24gV2Vk LCBGZWIgMDMsIDIwMjEgYXQgMTI6MTI6MzFQTSArMDEwMCwgRmlsaXBwbyBTaXJvbmkgd3JvdGU6 Cj4+IEkgZG9uJ3QgZGlzYWdyZWUgb24gdGhlIGZpcnN0IHBhcnQgb2YgeW91ciBzZW50ZW5jZSwg dGhpcyBpcyBhIGJpZwo+PiBvdmVyc2lnaHQuCj4gCj4gQnV0IGl0IGlzIG5vdCB3aGF0IHlvdXIg Y29tbWl0IGxvZyBzdWdnZXN0cy4KCkkgY2FuIGRlZmluaXRlbHkgcmVwaHJhc2UgdGhlIGNvbW1p dC4KCj4+IE9uIHRoZSBvdGhlciBoYW5kLCB0aG9zZSBjb250cm9sbGVycyBhcmUgb3V0IHRoZXJl IGFuZCBhcmUgaW4gdXNlIGJ5IGEgbG90Cj4+IG9mIGN1c3RvbWVycy4gIFdlIGNhbiBrZWVwIHJl bHlpbmcgb24gbHVjaywgaG9waW5nIHRoYXQgY3VzdG9tZXJzIGRvbid0IHJ1bgo+PiBpbnRvIHRy b3VibGVzIG9yIHdlIGNhbiBtZXJnZSBhIGZldyBsaW5lcyBvZiBjb2RlIDopCj4gCj4gWW91ciBw YXRjaCBkb2VzIG5vdCBqdXN0IHF1aXJrIGEgZmV3IGNvbnRyb2xsZXJzIG91dCB0aGVyZSwgYnV0 IGFsbAo+IGN1cnJlbnQgYW5kIGZ1dHVyZSBjb250cm9sbGVycyB3aXRoIGFuIEFtYXpvbiB2ZW5k b3IgSUQuICBXZSBjb3VsZAo+IHByb2JhYmx5IHRhbGsgYWJvdXQgcXVpcmtpbmcgYW4gZXhpc3Rp bmcgdmVuZG9yIElEIG9yIHR3byBhcyBsb25nIGFzCj4gdGhpcyBkb2Vzbid0IGhhcHBlbiBmb3Ig ZnV0dXJlIGhhcmR3YXJlLgoKSSBrbm93IHRoYXQgdGhlIGhhcmR3YXJlIHRlYW0gaXMgd29ya2lu ZyBvbiB0aGlzIGJ1dCBJIGRvbid0IGtub3cgdGhlIAp0aW1lbGluZXMgYW5kIHRoZXJlIGFyZSBh IGZldyB1cGNvbWluZyBjb250cm9sbGVycyAtIG9mIHdoaWNoIEkgZG9uJ3QgCmtub3cgdGhlIGRl dmljZSBpZHMgeWV0IC0gdGhhdCBoYXZlIHRoZSBzYW1lIGlzc3VlLgoKVG8gYXZvaWQgaXNzdWVz LCBpdCBpcyBlYXNpZXIgdG8gYXBwbHkgdGhlIHF1aXJrIHRvIGFsbCBBbWF6b24gTlZNZSAKY29u dHJvbGxlcnMgZm9yIG5vdyB0aWxsIHRoZSBuZXcgbGluZXMgb2YgY29udHJvbGxlcnMgd2l0aCB0 aGUgZml4IGNvbWVzIApvdXQuICBBdCB0aGF0IHBvaW50LCB3ZSdsbCBiZSBhYmxlIHRvIHJlc3Ry aWN0IHRoZSBhcHBsaWNhdGlvbiB0byB0aGUgCmtub3duIGJhZCBjb250cm9sbGVycy4KCgoKQW1h em9uIERldmVsb3BtZW50IENlbnRlciBHZXJtYW55IEdtYkgKS3JhdXNlbnN0ci4gMzgKMTAxMTcg QmVybGluCkdlc2NoYWVmdHNmdWVocnVuZzogQ2hyaXN0aWFuIFNjaGxhZWdlciwgSm9uYXRoYW4g V2Vpc3MKRWluZ2V0cmFnZW4gYW0gQW10c2dlcmljaHQgQ2hhcmxvdHRlbmJ1cmcgdW50ZXIgSFJC IDE0OTE3MyBCClNpdHo6IEJlcmxpbgpVc3QtSUQ6IERFIDI4OSAyMzcgODc5CgoK