From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4EC8C61D90 for ; Tue, 21 Nov 2023 18:18:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5VKZ-00018W-47; Tue, 21 Nov 2023 13:18:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5VKX-00018E-PT; Tue, 21 Nov 2023 13:18:37 -0500 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3] helo=gandalf.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5VKS-00013M-Ez; Tue, 21 Nov 2023 13:18:37 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4SZXgR66ptz4wy1; Wed, 22 Nov 2023 05:18:27 +1100 (AEDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SZXgQ1cZZz4wx5; Wed, 22 Nov 2023 05:18:25 +1100 (AEDT) Message-ID: <396d1103-1434-45f2-bebe-eacdb72978a7@kaod.org> Date: Tue, 21 Nov 2023 19:18:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/11] ppc/pnv: Add a pca9554 I2C device to powernv10-rainier Content-Language: en-US To: Glenn Miles , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= References: <20231120235112.1951342-1-milesg@linux.vnet.ibm.com> <20231120235112.1951342-11-milesg@linux.vnet.ibm.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <20231120235112.1951342-11-milesg@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=nm9w=HC=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, FORGED_SPF_HELO=1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/21/23 00:51, Glenn Miles wrote: > For powernv10-rainier, the Power Hypervisor code expects to see a > pca9554 device connected to the 3rd PNV I2C engine on port 1 at I2C > address 0x25 (or left-justified address of 0x4A). This is used by > the hypervisor code to detect if a "Cable Card" is present. > > Signed-off-by: Glenn Miles Reviewed-by: Cédric Le Goater Thanks, C. > --- > > Changes from previous version: > - Code moved from pnv_chip_power10_realize to pnv_rainier_i2c_init > > hw/misc/Kconfig | 4 ++++ > hw/misc/meson.build | 1 + > hw/ppc/Kconfig | 1 + > hw/ppc/pnv.c | 6 ++++++ > 4 files changed, 12 insertions(+) > > diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig > index cc8a8c1418..c347a132c2 100644 > --- a/hw/misc/Kconfig > +++ b/hw/misc/Kconfig > @@ -34,6 +34,10 @@ config PCA9552 > bool > depends on I2C > > +config PCA9554 > + bool > + depends on I2C > + > config I2C_ECHO > bool > default y if TEST_DEVICES > diff --git a/hw/misc/meson.build b/hw/misc/meson.build > index 36c20d5637..c39410e4a7 100644 > --- a/hw/misc/meson.build > +++ b/hw/misc/meson.build > @@ -4,6 +4,7 @@ system_ss.add(when: 'CONFIG_FW_CFG_DMA', if_true: files('vmcoreinfo.c')) > system_ss.add(when: 'CONFIG_ISA_DEBUG', if_true: files('debugexit.c')) > system_ss.add(when: 'CONFIG_ISA_TESTDEV', if_true: files('pc-testdev.c')) > system_ss.add(when: 'CONFIG_PCA9552', if_true: files('pca9552.c')) > +system_ss.add(when: 'CONFIG_PCA9554', if_true: files('pca9554.c')) > system_ss.add(when: 'CONFIG_PCI_TESTDEV', if_true: files('pci-testdev.c')) > system_ss.add(when: 'CONFIG_UNIMP', if_true: files('unimp.c')) > system_ss.add(when: 'CONFIG_EMPTY_SLOT', if_true: files('empty_slot.c')) > diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig > index f77ca773cf..2302778265 100644 > --- a/hw/ppc/Kconfig > +++ b/hw/ppc/Kconfig > @@ -33,6 +33,7 @@ config POWERNV > select FDT_PPC > select PCI_POWERNV > select PCA9552 > + select PCA9554 > > config PPC405 > bool > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index c29a136465..54ebef789e 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -1918,6 +1918,12 @@ static void pnv_rainier_i2c_init(PnvMachineState *pnv) > qdev_get_gpio_in(DEVICE(hotplug), 8)); > qdev_connect_gpio_out(DEVICE(hotplug), 4, > qdev_get_gpio_in(DEVICE(hotplug), 9)); > + > + /* > + * Add a PCA9554 I2C device for cable card presence detection > + * to engine 2, bus 1, address 0x25 > + */ > + i2c_slave_create_simple(chip10->i2c[2].busses[1], "pca9554", 0x25); > } > } >