From: "Stephan Müller" <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: shash - Fix zero-length shash ahash digest crash
Date: Mon, 09 Oct 2017 17:52:48 +0200 [thread overview]
Message-ID: <3972541.GrDicMXGHY@positron.chronox.de> (raw)
In-Reply-To: <20171009153002.GA7963@gondor.apana.org.au>
Am Montag, 9. Oktober 2017, 17:30:02 CEST schrieb Herbert Xu:
Hi Herbert,
> The shash ahash digest adaptor function may crash if given a
> zero-length input together with a null SG list. This is because
> it tries to read the SG list before looking at the length.
>
> This patch fixes it by checking the length first.
The patch fixes the issue.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: Stephan Müller<smueller@chronox.de>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Stephan Müller <smueller@chronox.de>
Ciao
Stephan
next prev parent reply other threads:[~2017-10-09 15:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 6:22 [PATCH 0/2] fix authenc() kernel crash Stephan Müller
2017-09-24 6:24 ` [PATCH 1/2] crypto: skcipher - noop for enc/dec with NULL data Stephan Müller
2017-10-07 2:46 ` Herbert Xu
2017-10-07 2:49 ` Stephan Müller
2017-10-07 2:51 ` Herbert Xu
2017-10-07 2:53 ` Stephan Müller
2017-10-07 3:07 ` Herbert Xu
2017-10-07 3:21 ` Stephan Müller
2017-10-07 3:29 ` Herbert Xu
2017-10-07 12:56 ` Stephan Müller
2017-10-09 14:19 ` Herbert Xu
2017-10-09 15:13 ` Stephan Müller
2017-10-09 15:30 ` [PATCH v2] crypto: shash - Fix zero-length shash ahash digest crash Herbert Xu
2017-10-09 15:52 ` Stephan Müller [this message]
2017-09-24 6:25 ` [PATCH 2/2] crypto: shash - no kmap of zero SG Stephan Müller
2017-10-07 2:44 ` Herbert Xu
2017-09-24 6:28 ` [PATCH 0/2] fix authenc() kernel crash Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3972541.GrDicMXGHY@positron.chronox.de \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.