From: David Howells <dhowells@redhat.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: dhowells@redhat.com, lkml <linux-kernel@vger.kernel.org>,
Ashwin Ganti <ashwin.ganti@gmail.com>, Greg KH <greg@kroah.com>,
rsc@swtch.com, ericvh@gmail.com,
linux-security-module@vger.kernel.org,
Ron Minnich <rminnich@gmail.com>,
jt.beard@gmail.com, Andrew Morgan <morgan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Eric Paris <eparis@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Kyle Moffett <kyle@moffetthome.net>,
Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH 1/3] p9auth: split core function out of some set*{u,g}id functions
Date: Tue, 04 May 2010 15:52:19 +0100 [thread overview]
Message-ID: <3976.1272984739@redhat.com> (raw)
In-Reply-To: <20100427164245.GA7530@us.ibm.com>
Serge E. Hallyn <serue@us.ibm.com> wrote:
> Break the core functionality of set{fs,res}{u,g}id into cred_setX
> which performs the access checks based on current_cred(), but performs
> the requested change on a passed-in cred.
>
> Export the helpers, since p9auth can be compiled as a module. It
> might be worth not allowing modular p9auth to avoid having to export
> them.
>
> Really the setfs{u,g}id helper isn't needed, but move it as
> well to keep the code consistent.
>
> This patch also changes set_user() to use new->user->user_ns. While
> technically not needed as all callers should have new->user->user_ns
> equal to current_userns(), it is more correct and may prevent surprises
> in the future.
>
> Changelog:
> Apr 24: (David Howells) make cred_setresuid etc extern, and
> document the helpers in Documentation/credentials.txt.
>
> Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2010-05-04 14:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:41 [PATCH 0/3] p9auth fs: introduction Serge E. Hallyn
2010-04-27 16:42 ` [PATCH 1/3] p9auth: split core function out of some set*{u,g}id functions Serge E. Hallyn
2010-05-04 14:52 ` David Howells [this message]
2010-04-27 16:43 ` [PATCH 2/3] p9auth: add CAP_GRANT_ID to authorize use of /dev/caphash Serge E. Hallyn
2010-04-27 16:45 ` [PATCH 3/3] RFC: p9auth: add p9auth fs Serge E. Hallyn
2010-04-28 11:17 ` Oleg Nesterov
2010-04-28 15:10 ` Serge E. Hallyn
2010-04-28 15:39 ` Oleg Nesterov
2010-05-03 23:50 ` Serge E. Hallyn
2010-05-04 14:57 ` David Howells
2010-05-04 15:14 ` Serge E. Hallyn
-- strict thread matches above, loose matches on Subject: below --
2010-04-21 1:27 [PATCH 1/3] p9auth: split core function out of some set*{u,g}id functions Serge E. Hallyn
2010-04-21 10:46 ` David Howells
2010-04-21 13:40 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3976.1272984739@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ashwin.ganti@gmail.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=ericvh@gmail.com \
--cc=greg@kroah.com \
--cc=jt.beard@gmail.com \
--cc=kyle@moffetthome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=rdunlap@xenotime.net \
--cc=rminnich@gmail.com \
--cc=rsc@swtch.com \
--cc=serue@us.ibm.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.