From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
dev@dpdk.org, stable@dpdk.org,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD
Date: Wed, 05 Jun 2019 15:14:04 +0200 [thread overview]
Message-ID: <3976742.XO3IndD6m0@xps> (raw)
In-Reply-To: <20190605125012.GD1550@bricha3-MOBL.ger.corp.intel.com>
05/06/2019 14:50, Bruce Richardson:
> On Wed, Jun 05, 2019 at 01:30:26PM +0200, David Marchand wrote:
> > Caught on FreeBSD 12:
> >
> > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
> > struct in_addr ip_src,ip_dst; /* source and dest address */
> > ^~~~~~
> >
> > On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
> > But actually, this header is not used in the example, just remove it.
> >
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> This should knock off one of the CI build errors once merged, I hope!
> Thanks for doing the patch.
Applied, thanks
prev parent reply other threads:[~2019-06-05 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 9:06 [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD David Marchand
2019-06-05 9:25 ` Thomas Monjalon
2019-06-05 9:36 ` David Marchand
2019-06-05 9:52 ` Thomas Monjalon
2019-06-05 10:32 ` David Marchand
2019-06-05 11:30 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-06-05 12:50 ` Bruce Richardson
2019-06-05 13:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3976742.XO3IndD6m0@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.