From: David Howells <dhowells@redhat.com>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: dhowells@redhat.com, Johannes Berg <johannes@sipsolutions.net>,
netfs@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v6.13] fs/netfs/read_collect: fix crash due to uninitialized `prev` variable
Date: Fri, 14 Feb 2025 13:03:48 +0000 [thread overview]
Message-ID: <3978535.1739538228@warthog.procyon.org.uk> (raw)
In-Reply-To: <20250211093432.3524035-1-max.kellermann@ionos.com>
Max Kellermann <max.kellermann@ionos.com> wrote:
> prev = list_prev_entry(subreq, rreq_link);
> ...
> + if (subreq->start == prev->start + prev->len) {
> + prev = list_prev_entry(subreq, rreq_link);
Actually, that doubles the setting of prev redundantly. It shouldn't hurt,
but we might want to remove the inner one.
David
next prev parent reply other threads:[~2025-02-14 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 9:34 [PATCH v6.13] fs/netfs/read_collect: fix crash due to uninitialized `prev` variable Max Kellermann
2025-02-11 9:36 ` kernel test robot
2025-02-14 12:53 ` David Howells
2025-02-14 12:57 ` Max Kellermann
2025-02-14 13:03 ` David Howells [this message]
2025-02-14 13:08 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3978535.1739538228@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=netfs@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.