From: "Voipio Riku" <Riku.Voipio@movial.fi>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (w83781d) Add missing curly braces
Date: Fri, 26 Oct 2007 22:28:08 +0000 [thread overview]
Message-ID: <39787.80.222.56.248.1193437688.squirrel@webmail.movial.fi> (raw)
In-Reply-To: <20071025131101.364e7c58@hyperion.delvare>
> Missing curly braces cause an if statement to be evaluated when it
> shouldn't. It happens to be harmless, but that's still worth fixing.
> Thanks to Riku Voipio for reporting.
This is clearly the correct fix:
Acked-By: Riku Voipio <riku.voipio@movial.fi>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/hwmon/w83781d.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.24-rc1.orig/drivers/hwmon/w83781d.c 2007-10-25
> 12:58:24.000000000 +0200
> +++ linux-2.6.24-rc1/drivers/hwmon/w83781d.c 2007-10-25 13:06:00.000000000
> +0200
> @@ -1121,12 +1121,13 @@ w83781d_create_files(struct device *dev,
> &sensor_dev_attr_temp3_beep.dev_attr)))
> return err;
>
> - if (kind != w83781d)
> + if (kind != w83781d) {
> err = sysfs_chmod_file(&dev->kobj,
> &sensor_dev_attr_temp3_alarm.dev_attr.attr,
> S_IRUGO | S_IWUSR);
> if (err)
> return err;
> + }
> }
>
> if (kind != w83781d && kind != as99127f) {
>
>
> --
> Jean Delvare
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-10-26 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 11:11 [lm-sensors] [PATCH] hwmon: (w83781d) Add missing curly braces Jean Delvare
2007-10-26 22:28 ` Voipio Riku [this message]
2007-10-28 17:41 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39787.80.222.56.248.1193437688.squirrel@webmail.movial.fi \
--to=riku.voipio@movial.fi \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.