From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Luca Boccassi <lboccass@brocade.com>
Cc: stable@dpdk.org,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD
Date: Fri, 23 Sep 2016 18:29:18 +0200 [thread overview]
Message-ID: <3978773.PpqE2HOjj0@xps13> (raw)
In-Reply-To: <CAATJJ0+BMZ3Oc7=ugNSBghei_Wq-J+m-fUA3P=iRRAYDd9pjnA@mail.gmail.com>
2016-09-14 12:54, Christian Ehrhardt:
> On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi <lboccass@brocade.com>
> wrote:
>
> > RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it
> > impossible to override via an environment variable, and forces users
> > to pass it inline in the make call.
> > Use ?= instead to have it pick up the environment variable as well.
> >
> > Cc: <stable@dpdk.org>
> > Signed-off-by: Luca Boccassi <lboccass@brocade.com>
>
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
I'm surprised you need to pass it via an environment variable.
Applied, thanks
prev parent reply other threads:[~2016-09-23 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 10:50 [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD Luca Boccassi
2016-09-14 10:54 ` Christian Ehrhardt
2016-09-23 16:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3978773.PpqE2HOjj0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=lboccass@brocade.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.