From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, iryzhov@nfware.com, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] kni: fix use-after-free when kni release
Date: Sun, 27 Feb 2022 21:11:09 +0100 [thread overview]
Message-ID: <3979221.CQOukoFCf9@thomas> (raw)
In-Reply-To: <48145833-dde0-2e7f-798f-2fbbe2b179bc@intel.com>
15/02/2022 20:11, Ferruh Yigit:
> On 2/14/2022 6:41 PM, Ferruh Yigit wrote:
> > On 2/9/2022 7:35 AM, Min Hu (Connor) wrote:
> >> From: Huisong Li <lihuisong@huawei.com>
> >>
> >> The "kni_dev" is the private data of the "net_device" in kni, and allocated
> >> with the "net_device" by calling "alloc_netdev()". The "net_device" is
> >> freed by calling "free_netdev()" when kni release. The freed memory
> >> includes the "kni_dev". So After "kni_dev" should not be accessed after
> >> "net_device" is released.
> >>
> >
> > The problem description looks valid and change looks good to me,
> >
> > only list_del after remove is like this for years, I wonder how
> > it is not caught until now, or if we are missing something, I
> > want to test some before ack, which I will do in next few days.
>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks.
prev parent reply other threads:[~2022-02-27 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 2:43 [PATCH] kni: fix use-after-free when kni release Min Hu (Connor)
2022-02-08 12:41 ` Igor Ryzhov
2022-02-09 7:35 ` Min Hu (Connor)
2022-02-09 12:41 ` Igor Ryzhov
2022-02-09 7:35 ` [PATCH v2] " Min Hu (Connor)
2022-02-14 18:41 ` Ferruh Yigit
2022-02-15 19:11 ` Ferruh Yigit
2022-02-27 20:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3979221.CQOukoFCf9@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.