From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 2/3] lpm: add support for NEON Date: Tue, 01 Mar 2016 18:46:04 +0100 Message-ID: <3982491.QlXm5U4YLd@xps13> References: <1454040645-23864-1-git-send-email-jerin.jacob@caviumnetworks.com> <1455280123-9311-1-git-send-email-jerin.jacob@caviumnetworks.com> <1455280123-9311-3-git-send-email-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, viktorin@rehivetech.com To: Jerin Jacob Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id DA4FBAA39 for ; Tue, 1 Mar 2016 18:47:40 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id n186so49081510wmn.1 for ; Tue, 01 Mar 2016 09:47:40 -0800 (PST) In-Reply-To: <1455280123-9311-3-git-send-email-jerin.jacob@caviumnetworks.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-12 17:58, Jerin Jacob: > # fails to compile on ARM > -CONFIG_RTE_LIBRTE_LPM=n > -CONFIG_RTE_LIBRTE_TABLE=n > -CONFIG_RTE_LIBRTE_PIPELINE=n The associated examples cannot compile. Maybe it's too early to enable them. What about updating the comment to state that only examples fail? > --- a/lib/librte_lpm/Makefile > +++ b/lib/librte_lpm/Makefile > +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h Simpler: ifneq ($(CONFIG_RTE_ARCH_ARM)$(CONFIG_RTE_ARCH_ARM64),nn)