From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C30C43334 for ; Tue, 28 Jun 2022 05:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243538AbiF1FxH (ORCPT ); Tue, 28 Jun 2022 01:53:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234982AbiF1FxH (ORCPT ); Tue, 28 Jun 2022 01:53:07 -0400 Received: from m1550.mail.126.com (m1550.mail.126.com [220.181.15.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5A6EEFF3; Mon, 27 Jun 2022 22:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=BzQjt GGE+XK5zIt6YFBt3VAbazb6iNZuycDB1eB0QlA=; b=nL7+0nLCjn4wIkPBWQtoE Nce376O50kX3NojsxsH8/H3YrzfOpUon5NrISdApic45n7LO9xeYGNqhn13KTB6m q+bZIVl9wz1fK8SWQ99fQ86WM4Se+toMXbJBrq8dw/YzjqAJEg5SqXv+E9aH48zC mqGNPPysCMZ+ro8WBcqTQM= Received: from windhl$126.com ( [124.16.139.61] ) by ajax-webmail-wmsvr50 (Coremail) ; Tue, 28 Jun 2022 13:52:53 +0800 (CST) X-Originating-IP: [124.16.139.61] Date: Tue, 28 Jun 2022 13:52:53 +0800 (CST) From: "Liang He" To: "Tony Lindgren" Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re:Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20220113(9671e152) Copyright (c) 2002-2022 www.mailtech.cn 126com In-Reply-To: References: <20220617035548.4003393-1-windhl@126.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=GBK MIME-Version: 1.0 Message-ID: <39ad3f64.3de2.181a8dea7a0.Coremail.windhl@126.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: MsqowADHHPE1l7piefI+AA--.21879W X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi3BIuF1pED0WRtAAEsC X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org CgoKQXQgMjAyMi0wNi0yOCAxMjozODo0OSwgIlRvbnkgTGluZGdyZW4iIDx0b255QGF0b21pZGUu Y29tPiB3cm90ZToKPiogTGlhbmcgSGUgPHdpbmRobEAxMjYuY29tPiBbMjIwNjE3IDA2OjUxXToK Pj4gSW4gb21hcDRfc3JhbV9pbml0KCksIG9mX2ZpbmRfY29tcGF0aWJsZV9ub2RlKCkgd2lsbCBy ZXR1cm4gYSBub2RlCj4+IHBvaW50ZXIgd2l0aCByZWZjb3VudCBpbmNyZW1lbnRlZC4gV2Ugc2hv dWxkIHVzZSBvZl9ub2RlX3B1dCgpIHdoZW4KPj4gaXQgaXMgbm90IHVzZWQgYW55bW9yZS4KPj4g Cj4+IFNpZ25lZC1vZmYtYnk6IExpYW5nIEhlIDx3aW5kaGxAMTI2LmNvbT4KPj4gLS0tCj4+ICBh cmNoL2FybS9tYWNoLW9tYXAyL29tYXA0LWNvbW1vbi5jIHwgMSArCj4+ICAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKykKPj4gCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLW9tYXAy L29tYXA0LWNvbW1vbi5jIGIvYXJjaC9hcm0vbWFjaC1vbWFwMi9vbWFwNC1jb21tb24uYwo+PiBp bmRleCA2ZDFlYjRlZWZlZmUuLmU5ODFiZjU3ZTY0ZiAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm0v bWFjaC1vbWFwMi9vbWFwNC1jb21tb24uYwo+PiArKysgYi9hcmNoL2FybS9tYWNoLW9tYXAyL29t YXA0LWNvbW1vbi5jCj4+IEBAIC0xMzUsNiArMTM1LDcgQEAgc3RhdGljIGludCBfX2luaXQgb21h cDRfc3JhbV9pbml0KHZvaWQpCj4+ICAJCXByX3dhcm4oIiVzOlVuYWJsZSB0byBhbGxvY2F0ZSBz cmFtIG5lZWRlZCB0byBoYW5kbGUgZXJyYXRhIEk2ODhcbiIsCj4+ICAJCQlfX2Z1bmNfXyk7Cj4+ ICAJc3JhbV9wb29sID0gb2ZfZ2VuX3Bvb2xfZ2V0KG5wLCAic3JhbSIsIDApOwo+PiArCW9mX25v ZGVfcHV0KG5wKTsKPj4gIAlpZiAoIXNyYW1fcG9vbCkKPj4gIAkJcHJfd2FybigiJXM6VW5hYmxl IHRvIGdldCBzcmFtIHBvb2wgbmVlZGVkIHRvIGhhbmRsZSBlcnJhdGEgSTY4OFxuIiwKPj4gIAkJ CV9fZnVuY19fKTsKPgo+SGVyZSB0b28gc3JhbV9wb29sIGlzIHVzZWQgYWZ0Z2VyIG9mX25vZGVf cHV0KCkuCj4KPlJlZ2FyZHMsCj4KPlRvbnkKClRoYW5rcywgVG9ueS4KCkkgd2lsbCBzZW5kIGEg bmV3IHBhdGNoIHRvIGZpeCB0aGUgb3JkZXIgcHJvYmxlbS4KCkxpYW5nCgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C90D1C43334 for ; Tue, 28 Jun 2022 06:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GqXimU/+R8sw8qRLu4BxJzO/4Eti5ohQjgMwYHteM7M=; b=x1gO7zW94nYa55 +x5pF/5PQVNrj3ssBGZr9I4gtc6OHw4EhYbwXa6/KDR4t5JcXCyhpEif0R5tw5wSMJIgJrXsvD+o3 hXACESTGTN749Gs/hwJ5c5YVa6Va/3JOjYBz0knGFPPVQC9wOcksnM7OzVIy2Sr4mGpvYTsSjH8fN CTtrYkOV+qX2IbLCybxGJt6veUzNIsDbHg+0615cx78GiSYmtIEFCkphyBESG8PXBXm9EoS5erD63 orueLuql8/NwaRCiyb+3rDNKi7Bp+0l8QAMRbjPg7imS+jAwpW085bOp0oan4OZdbsKF70iq1zzOU 4rwIqt7JtBTYeyn4xwRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o64GU-004WFx-4G; Tue, 28 Jun 2022 05:59:59 +0000 Received: from m1550.mail.126.com ([220.181.15.50]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o649k-004TMn-Vb for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 05:53:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=BzQjt GGE+XK5zIt6YFBt3VAbazb6iNZuycDB1eB0QlA=; b=nL7+0nLCjn4wIkPBWQtoE Nce376O50kX3NojsxsH8/H3YrzfOpUon5NrISdApic45n7LO9xeYGNqhn13KTB6m q+bZIVl9wz1fK8SWQ99fQ86WM4Se+toMXbJBrq8dw/YzjqAJEg5SqXv+E9aH48zC mqGNPPysCMZ+ro8WBcqTQM= Received: from windhl$126.com ( [124.16.139.61] ) by ajax-webmail-wmsvr50 (Coremail) ; Tue, 28 Jun 2022 13:52:53 +0800 (CST) X-Originating-IP: [124.16.139.61] Date: Tue, 28 Jun 2022 13:52:53 +0800 (CST) From: "Liang He" To: "Tony Lindgren" Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re:Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20220113(9671e152) Copyright (c) 2002-2022 www.mailtech.cn 126com In-Reply-To: References: <20220617035548.4003393-1-windhl@126.com> MIME-Version: 1.0 Message-ID: <39ad3f64.3de2.181a8dea7a0.Coremail.windhl@126.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: MsqowADHHPE1l7piefI+AA--.21879W X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi3BIuF1pED0WRtAAEsC X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_225301_848730_D2651F3A X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org At 2022-06-28 12:38:49, "Tony Lindgren" wrote: >* Liang He [220617 06:51]: >> In omap4_sram_init(), of_find_compatible_node() will return a node >> pointer with refcount incremented. We should use of_node_put() when >> it is not used anymore. >> >> Signed-off-by: Liang He >> --- >> arch/arm/mach-omap2/omap4-common.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c >> index 6d1eb4eefefe..e981bf57e64f 100644 >> --- a/arch/arm/mach-omap2/omap4-common.c >> +++ b/arch/arm/mach-omap2/omap4-common.c >> @@ -135,6 +135,7 @@ static int __init omap4_sram_init(void) >> pr_warn("%s:Unable to allocate sram needed to handle errata I688\n", >> __func__); >> sram_pool = of_gen_pool_get(np, "sram", 0); >> + of_node_put(np); >> if (!sram_pool) >> pr_warn("%s:Unable to get sram pool needed to handle errata I688\n", >> __func__); > >Here too sram_pool is used aftger of_node_put(). > >Regards, > >Tony Thanks, Tony. I will send a new patch to fix the order problem. Liang _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel