From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nabige Aala <nabige.aala@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, arpit.saini@oss.qualcomm.com,
mohit.dsor@oss.qualcomm.com
Subject: Re: [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support
Date: Sun, 28 Jun 2026 10:45:39 +0200 [thread overview]
Message-ID: <39b4dd07-d0f5-458e-8739-0572b5d50870@kernel.org> (raw)
In-Reply-To: <20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com>
On 27/06/2026 12:01, Nabige Aala wrote:
> From: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
>
> Device tree changes to support lt9611uxd hdmi-dsi driver.
>
> Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Incomplete DCO
...
> +
> vreg_wcn_3p3: regulator-wcn-3p3 {
> compatible = "regulator-fixed";
> regulator-name = "wcn_3p3";
> @@ -68,6 +98,78 @@ vreg_pmu_ch1: ldo4 {
> };
> };
>
> +&i2c4 {
> + status = "okay";
> +
> + lt9611uxd: lt9611uxd@41 {
No. Nice try. Instead of fixing broken driver (I reported this), you
send broken workaround which is in clear violations of coding style and
DT spec.
That's a poor way to upstream things. Just throwing the code over the wall.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-28 8:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
2026-06-27 10:01 ` [PATCH 1/5] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
2026-06-28 12:35 ` Dmitry Baryshkov
2026-06-27 10:01 ` [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
2026-06-28 12:30 ` Dmitry Baryshkov
2026-06-28 12:30 ` Dmitry Baryshkov
2026-06-27 10:01 ` [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-28 8:44 ` Krzysztof Kozlowski
2026-06-27 10:01 ` [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
2026-06-28 12:36 ` Dmitry Baryshkov
2026-06-27 10:01 ` [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support Nabige Aala
2026-06-28 8:45 ` Krzysztof Kozlowski [this message]
2026-06-28 12:38 ` Dmitry Baryshkov
2026-06-28 12:24 ` [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b4dd07-d0f5-458e-8739-0572b5d50870@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=arpit.saini@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohit.dsor@oss.qualcomm.com \
--cc=nabige.aala@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.