From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Laatz, Kevin" Subject: Re: [PATCH] event/sw: add unlikely branch predict Date: Wed, 14 Mar 2018 13:06:35 +0000 Message-ID: <39dc23d4-bac3-7571-eaa8-a05c9f793efc@intel.com> References: <1519762085-77659-1-git-send-email-vipin.varghese@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, harry.van.haaren@intel.com To: Vipin Varghese Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 438C75F28 for ; Wed, 14 Mar 2018 14:06:39 +0100 (CET) In-Reply-To: <1519762085-77659-1-git-send-email-vipin.varghese@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 27/02/2018 20:08, Vipin Varghese wrote: > For most run cases 'sw->started' holds true. Adding a branch prediction > suggestion to compiler helps as this is first conditional check just > after entering the function. > > Signed-off-by: Vipin Varghese > --- > drivers/event/sw/sw_evdev_scheduler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c > index 3106eb3..17bd4c0 100644 > --- a/drivers/event/sw/sw_evdev_scheduler.c > +++ b/drivers/event/sw/sw_evdev_scheduler.c > @@ -508,7 +508,7 @@ sw_event_schedule(struct rte_eventdev *dev) > uint32_t i; > > sw->sched_called++; > - if (!sw->started) > + if (unlikely(!sw->started)) > return; > > do { Acked-by: Kevin Laatz