From: Mimi Zohar <zohar@linux.ibm.com>
To: Coiby Xu <coxu@redhat.com>, linux-integrity@vger.kernel.org
Cc: itrymybest80@protonmail.com,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring
Date: Tue, 02 Jan 2024 12:54:02 -0500 [thread overview]
Message-ID: <39e5612eb2d4dea2759310ccce39c1ad40b5388f.camel@linux.ibm.com> (raw)
In-Reply-To: <20231227044156.166009-1-coxu@redhat.com>
Hi Coiby,
According to https://docs.kernel.org/process/submitting-patches.html,the summary line should be no more than 70 - 75 characters.
On Wed, 2023-12-27 at 12:41 +0800, Coiby Xu wrote:
> Currently when the kernel fails to add a cert to the .machine keyring,
> it will throw an error immediately in the function integrity_add_key.
>
> Since the kernel will try adding to the .platform keyring next or throw
> an error (in the caller of integrity_add_key i.e. add_to_machine_keyring),
> so there is no need to throw an error immediately in integrity_add_key.
>
> Reported-by: itrymybest80@protonmail.com
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2239331
> Signed-off-by: Coiby Xu <coxu@redhat.com>
Otherwise, the patch looks good.
--
thanks,
Mim
next prev parent reply other threads:[~2024-01-02 17:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 4:41 [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring Coiby Xu
2024-01-02 17:33 ` Eric Snowberg
2024-01-05 13:27 ` Coiby Xu
2024-01-02 17:54 ` Mimi Zohar [this message]
2024-01-05 13:27 ` Coiby Xu
2024-01-05 14:59 ` Mimi Zohar
2024-01-09 0:30 ` Coiby Xu
2024-01-03 14:09 ` Jarkko Sakkinen
2024-01-05 13:20 ` Coiby Xu
2024-01-05 16:02 ` Jarkko Sakkinen
2024-01-09 0:27 ` Coiby Xu
2024-01-09 0:24 ` [PATCH v2] integrity: eliminate unnecessary "Problem loading X.509 certificate" msg Coiby Xu
2024-02-16 11:10 ` Coiby Xu
2024-02-16 13:10 ` Mimi Zohar
2024-03-06 10:57 ` Maxime Ripard
2024-03-06 11:55 ` Mimi Zohar
2024-03-06 12:40 ` Maxime Ripard
2024-03-13 2:37 ` Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e5612eb2d4dea2759310ccce39c1ad40b5388f.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=coxu@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=itrymybest80@protonmail.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.