From: "Arnaldo Carvalho de Melo" <arnaldo.melo@gmail.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH v2 - RESEND]: [CCID 3]: Track RX/TX packet size `s' using moving-average
Date: Sun, 26 Nov 2006 17:59:55 +0000 [thread overview]
Message-ID: <39e6f6c70611260959g57f43067p979cb308123f1c5b@mail.gmail.com> (raw)
On 11/23/06, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> @@ -1022,6 +1047,9 @@ static void ccid3_hc_rx_packet_recv(stru
> if (DCCP_SKB_CB(skb)->dccpd_type = DCCP_PKT_ACK)
> return;
>
> + payload_size = skb->len - dccp_hdr(skb)->dccph_doff * 4;
Should't we use (skb->len - dccp_hdr_len(skb)) to take into account
the different DCCP packet size header lengths? We can get payload in
other kinds of packets than just DATA, and even on DATAACK we should
not compute the sizeof(struct dccp_hdr_ack_bits) bytes into the
payload, no?
- Arnaldo
next reply other threads:[~2006-11-26 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 17:59 Arnaldo Carvalho de Melo [this message]
2006-11-27 10:16 ` [PATCH v2 - RESEND]: [CCID 3]: Track RX/TX packet size `s' using moving-average Gerrit Renker
-- strict thread matches above, loose matches on Subject: below --
2006-11-23 14:53 Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e6f6c70611260959g57f43067p979cb308123f1c5b@mail.gmail.com \
--to=arnaldo.melo@gmail.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.