Re: [OE-core] [PATCH] staging.bbclass: run prepare_recipe_sysroot after unpack, not fetch

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2023-03-09 at 11:32 +0100, Alexander Kanavin wrote:
> Otherwise nasty races between unpack and prepare_recipe_sysroot can occur:
> 
> ERROR: Bitbake Fetcher Error: FetchError('Fetch command export PSEUDO_DISABLED=1; export PATH="/srv/work/alex/poky/scripts/native-intercept:/srv/storage/alex/yocto/build-64-alt/tmp/sysroots-uninative/x86_64-linux/usr/bin:/srv/storage/alex/yocto/build-64-alt/tmp/work/x86_64-linux/libslirp-native/4.7.0-r0/recipe-sysroot-native/usr/bin/python3-native:/srv/work/alex/poky/scripts:/srv/storage/alex/yocto/build-64-alt/tmp/work/x86_64-linux/libslirp-native/4.7.0-r0/recipe-sysroot-native/usr/bin/x86_64-linux:/srv/storage/alex/yocto/build-64-alt/tmp/work/x86_64-linux/libslirp-native/4.7.0-r0/recipe-sysroot-native/usr/bin:/srv/storage/alex/yocto/build-64-alt/tmp/work/x86_64-linux/libslirp-native/4.7.0-r0/recipe-sysroot-native/usr/sbin:/srv/storage/alex/yocto/build-64-alt/tmp/work/x86_64-linux/libslirp-native/4.7.0-r0/recipe-sysroot-native/usr/bin:/srv/storage/alex/yocto/build-64-alt/tmp/work/x86_64-linux/libslirp-native/4.7.0-r0/recipe-sysroot-native/sbin:/srv/storage/alex/yocto/build-64-alt/tmp/work/x86_64-linux/libslirp-native/4.7.0-r0/recipe-sysroot-native/bin:/srv/work/alex/poky/bitbake/bin:/srv/storage/alex/yocto/build-64-alt/tmp/hosttools"; export HOME="/home/alex"; git -c gc.autoDetach=false -c core.pager=cat checkout -B master 3ad1710a96678fe79066b1469cead4058713a1d9 failed with exit code 127, output:\npython3: error while loading shared libraries: libpython3.11.so.1.0: cannot open shared object file: No such file or directory\n', None)
> DEBUG: Python function base_do_unpack finished
> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  meta/classes-global/staging.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-global/staging.bbclass b/meta/classes-global/staging.bbclass
> index e6d0d1d55c..ade5c03cd9 100644
> --- a/meta/classes-global/staging.bbclass
> +++ b/meta/classes-global/staging.bbclass
> @@ -647,7 +647,7 @@ do_prepare_recipe_sysroot[deptask] = "do_populate_sysroot"
>  python do_prepare_recipe_sysroot () {
>      bb.build.exec_func("extend_recipe_sysroot", d)
>  }
> -addtask do_prepare_recipe_sysroot before do_configure after do_fetch
> +addtask do_prepare_recipe_sysroot before do_configure after do_unpack
>  
>  python staging_taskhandler() {
>      bbtasks = e.tasklist

Before we start changing core dependencies, we need to better
understand what happened there. Whilst this patch might fix this case,
we'd likely just leave races elsewhere as other tasks call git too.

Which recipe was this?
Why is git calling into python?
Why didn't the staging code to move libs into position before binaries
prevent this?

Cheers,

Richard