All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Andrey Panin <pazke@orbita.don.sitek.net>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] NIC drivers check_region() removal continues
Date: Fri, 10 Nov 2000 09:30:05 -0500	[thread overview]
Message-ID: <3A0C066D.BB6B0220@mandrakesoft.com> (raw)
In-Reply-To: <20001110142957.A8245@debian>

Andrey Panin wrote:
> 
> Hi all,
> 
> new net drivers patchset (against 2.4.0-test11-pre1) attached.
> 
> Modifications: check_region() removal, passing dev->name to
> request_region() & request_irq() etc.
> 
> Drivers affected: 3c501.c, 3c503.c, 3c505.c, 82596.c, eth16i.c, hp.c,
> hp-plus.c, ibmlana.c, ne2.c, seeq8005.c, smc-mca.c, smc-ultra.c,
> smc-ultra32.c

Most patches applied, thanks.  Comments:

3c505.c:  You must abort if dma_mem_alloc return value is null, not just
print a message.
82596.c:  Not applied.  My moving the "if checksum & 0x100" line, you
make the code comments incorrect.
eth16i.c:  Your diff was not created in the main linux directory...
seeq8005.c:  Applied, but you forgot dev->name in request_region

-- 
Jeff Garzik             |
Building 1024           | Would you like a Twinkie?
MandrakeSoft            |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2000-11-10 14:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-10 11:29 [PATCH] NIC drivers check_region() removal continues Andrey Panin
2000-11-10 14:30 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A0C066D.BB6B0220@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pazke@orbita.don.sitek.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.