From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: randy.dunlap@intel.com, linux-kernel@vger.kernel.org
Subject: Re: CONFIG_USB_HOTPLUG (was Patch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compile failure)
Date: Wed, 15 Nov 2000 15:40:13 -0500 [thread overview]
Message-ID: <3A12F4AD.6BA039B3@mandrakesoft.com> (raw)
In-Reply-To: <200011151745.JAA02400@adam.yggdrasil.com>
"Adam J. Richter" wrote:
> You were right: the
> __devinitdata being used in the USB drivers will probably crash the
> kernel if CONFIG_HOTPLUG is not defined and the USB code attempts to
> recover from an error by faking disconnect/reconnect.
[...]
> Until there is __usbdev{init,exit}{,data}, the incorrect
> __devinitdata qualifiers should be removed from the USB device
> drivers (but not from the host controller drivers, which are PCI drivers).
If a user hotplugs a device into a kernel which does not support
CONFIG_HOTPLUG, they are shooting themselves in the foot.
I don't see that __devinitdata should be removed.
*plonk*
--
Jeff Garzik |
Building 1024 | The chief enemy of creativity is "good" sense
MandrakeSoft | -- Picasso
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-15 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-15 17:45 CONFIG_USB_HOTPLUG (was Patch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compile failure) Adam J. Richter
2000-11-15 20:40 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-11-15 22:05 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A12F4AD.6BA039B3@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.