From: Dan Aizenstros <dan@vcubed.com>
To: Ralf Baechle <ralf@oss.sgi.com>
Cc: linux-mips@oss.sgi.com
Subject: Re: Multiple copies of pci-dma.c file.
Date: Thu, 23 Nov 2000 17:04:27 -0500 [thread overview]
Message-ID: <3A1D946B.CEF85110@vcubed.com> (raw)
In-Reply-To: 20001122165653.A6421@bacchus.dhis.org
Hello Ralf,
Should the dma_cache_inv actually be a dma_cache_wback_inv?
Also, the sni directory contains a dma.c which is they same
as pci-dma.c and should be removed.
Dan Aizenstros
Software Engineer
V3 Semicondutor Corp.
Ralf Baechle wrote:
>
> On Wed, Nov 22, 2000 at 09:30:32AM -0500, Dan Aizenstros wrote:
>
> > Is there any reason for having multiple copies of
> > the pci-dma.c file in Linux/MIPS. The are all
> > doing basically the same thing. We could have
> > just one copy in the arch/mips/lib directory
> > and have the Makefile build it if CONFIG_PCI
> > is defined.
>
> Sounds like a plan, done. Tell me if it breaks something ...
>
> Some chipsets have a builtin scatter / gather facility, those may need
> special variants of pci-dma.c for better support.
>
> > Also they appear to have an error in that they
> > convert the pointer that is returned from the
> > __get_free_pages function call into a KSEG1
> > address even if the pointer is NULL.
>
> Fixed.
>
> Ralf
next prev parent reply other threads:[~2000-11-23 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-22 14:30 Multiple copies of pci-dma.c file Dan Aizenstros
2000-11-22 15:56 ` Ralf Baechle
2000-11-23 22:04 ` Dan Aizenstros [this message]
2000-11-24 1:35 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A1D946B.CEF85110@vcubed.com \
--to=dan@vcubed.com \
--cc=linux-mips@oss.sgi.com \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.