From: Russell Kroll <rkroll@exploits.org>
To: alan@lxorguk.ukuu.org.uk, torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.4.0-prerelease: radio card request_region fixes
Date: Mon, 01 Jan 2001 06:01:15 -0600 [thread overview]
Message-ID: <3A50718B.mailOM11K4AFD@exploits.org> (raw)
Many of the radio card drivers got the request_region sense inverted and
make a horrible mess on insmod. I've tested the patches in this set for
radio-aimslab and radio-aztech locally. The others are "obviously
correct" since they are the same core code.
--- drivers/media/radio/radio-aimslab.c.stock Mon Jan 1 05:14:29 2001
+++ drivers/media/radio/radio-aimslab.c Mon Jan 1 05:14:35 2001
@@ -338,7 +338,7 @@
return -EINVAL;
}
- if (request_region(io, 2, "rtrack"))
+ if (!request_region(io, 2, "rtrack"))
{
printk(KERN_ERR "rtrack: port 0x%x already in use\n", io);
return -EBUSY;
--- drivers/media/radio/radio-aztech.c.stock Mon Jan 1 05:35:07 2001
+++ drivers/media/radio/radio-aztech.c Mon Jan 1 05:35:15 2001
@@ -289,7 +289,7 @@
return -EINVAL;
}
- if (request_region(io, 2, "aztech"))
+ if (!request_region(io, 2, "aztech"))
{
printk(KERN_ERR "aztech: port 0x%x already in use\n", io);
return -EBUSY;
--- drivers/media/radio/radio-rtrack2.c.stock Mon Jan 1 05:42:52 2001
+++ drivers/media/radio/radio-rtrack2.c Mon Jan 1 05:43:02 2001
@@ -230,7 +230,7 @@
printk(KERN_ERR "You must set an I/O address with io=0x20c or io=0x30c\n");
return -EINVAL;
}
- if (request_region(io, 4, "rtrack2"))
+ if (!request_region(io, 4, "rtrack2"))
{
printk(KERN_ERR "rtrack2: port 0x%x already in use\n", io);
return -EBUSY;
--- drivers/media/radio/radio-sf16fmi.c.stock Mon Jan 1 05:44:36 2001
+++ drivers/media/radio/radio-sf16fmi.c Mon Jan 1 05:44:43 2001
@@ -291,7 +291,7 @@
printk(KERN_ERR "You must set an I/O address with io=0x???\n");
return -EINVAL;
}
- if (request_region(io, 2, "fmi"))
+ if (!request_region(io, 2, "fmi"))
{
printk(KERN_ERR "fmi: port 0x%x already in use\n", io);
return -EBUSY;
--- drivers/media/radio/radio-terratec.c.stock Mon Jan 1 05:45:13 2001
+++ drivers/media/radio/radio-terratec.c Mon Jan 1 05:45:26 2001
@@ -309,7 +309,7 @@
printk(KERN_ERR "You must set an I/O address with io=0x???\n");
return -EINVAL;
}
- if (request_region(io, 2, "terratec"))
+ if (!request_region(io, 2, "terratec"))
{
printk(KERN_ERR "TerraTec: port 0x%x already in use\n", io);
return -EBUSY;
--- drivers/media/radio/radio-trust.c.stock Mon Jan 1 05:46:47 2001
+++ drivers/media/radio/radio-trust.c Mon Jan 1 05:46:51 2001
@@ -300,7 +300,7 @@
printk(KERN_ERR "You must set an I/O address with io=0x???\n");
return -EINVAL;
}
- if(request_region(io, 2, "Trust FM Radio")) {
+ if(!request_region(io, 2, "Trust FM Radio")) {
printk(KERN_ERR "trust: port 0x%x already in use\n", io);
return -EBUSY;
}
--- drivers/media/radio/radio-typhoon.c.stock Mon Jan 1 05:47:07 2001
+++ drivers/media/radio/radio-typhoon.c Mon Jan 1 05:47:15 2001
@@ -350,7 +350,7 @@
printk(KERN_INFO BANNER);
io = typhoon_unit.iobase;
- if (request_region(io, 8, "typhoon")) {
+ if (!request_region(io, 8, "typhoon")) {
printk(KERN_ERR "radio-typhoon: port 0x%x already in use\n",
typhoon_unit.iobase);
return -EBUSY;
--- drivers/media/radio/radio-zoltrix.c.stock Mon Jan 1 05:47:50 2001
+++ drivers/media/radio/radio-zoltrix.c Mon Jan 1 05:47:58 2001
@@ -361,7 +361,7 @@
}
zoltrix_radio.priv = &zoltrix_unit;
- if (request_region(io, 2, "zoltrix")) {
+ if (!request_region(io, 2, "zoltrix")) {
printk(KERN_ERR "zoltrix: port 0x%x already in use\n", io);
return -EBUSY;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2001-01-01 12:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A50718B.mailOM11K4AFD@exploits.org \
--to=rkroll@exploits.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.