From: Brian Gerst <bgerst@didntduck.org>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make drivers/scsi/seagate.c use ioremap instead of isa_{read,write} (241p11)
Date: Mon, 29 Jan 2001 17:08:09 -0500 [thread overview]
Message-ID: <3A75E9C9.15A19548@didntduck.org> (raw)
In-Reply-To: <20010129225907.M603@jaquet.dk>
Rasmus Andersen wrote:
>
> Hi.
>
> (I have not been able to find a probable current maintainer for
> this code.)
>
> The following patch makes drivers/scsi/seagate.c use ioremap
> instead of isa_{read, write}.
>
> It applies against ac12 and 241p11.
>
> Please comment, esp. on the size of the remappings.
This isn't the proper way to use ioremap. You should only ioremap once
when the driver is loaded and save the mapped address. Since ioremap
special cases ISA addresses, it doesn't add much overhead the way you
are doing it, but it is still not consistent with normal non-ISA usage
of ioremap.
--
Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2001-01-29 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-29 21:59 [PATCH] make drivers/scsi/seagate.c use ioremap instead of isa_{read,write} (241p11) Rasmus Andersen
2001-01-29 22:08 ` Brian Gerst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A75E9C9.15A19548@didntduck.org \
--to=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.