Re: 2.4.1-pre10 -> 2.4.1 klogd at 100% CPU ; 2.4.0 OK

[Padraig Brady <Padraig@AnteFacto.com>]

Chris Hanson wrote:

>    Date: Wed, 31 Jan 2001 17:48:50 +0000
>    From: Padraig Brady <Padraig@AnteFacto.com>
> 
>    Are you using the 3c59x driver?
> 
> Yes.

Can we sort this out once and for all? There are a few emails
everyday relating to this bug.

The following patch posted by "Troels Walsted Hansen" <troels@thule.no>
on Jan 11th fixes this. The problem is that when 2 consequtive
NULLs are sent to klogd it goes into a busy loop. Andrew Mortons
3c59x driver does this, but also on Jan 11th he replied that he had
fixed it. I'm using 2.4ac4 with no problems, so I presume some
of these patches have been lost along the way?

--- sysklogd-1.4.orig/klogd.c    Mon Sep 18 09:34:11 2000
+++ sysklogd-1.4/klogd.c    Thu Jan 11 09:26:10 2001
@@ -739,6 +758,13 @@
            break;  /* full line_buff or end of input buffer */
                 }

+               if( *ptr == '\0' ) /* zero byte */
+               {
+                  ptr++;    /* skip zero byte */
+                  space -= 1;
+                  len   -= 1;
+                  break;
+               }
                 if( *ptr == '\n' )  /* newline */
                 {
                    ptr++;    /* skip newline */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/